Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plex: 1.13.5.5291 -> 1.13.6.5339 #45701

Closed
wants to merge 1 commit into from
Closed

Plex: 1.13.5.5291 -> 1.13.6.5339 #45701

wants to merge 1 commit into from

Conversation

sjau
Copy link

@sjau sjau commented Aug 28, 2018

Motivation for this change

Plex: 1.13.5.5291 -> 1.13.6.5339

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Aug 28, 2018

Have you tested the update?

@Mic92
Copy link
Member

Mic92 commented Aug 28, 2018

cc @colemickens @Forkk @thoughtpolice @pjones @LnL7

@sjau
Copy link
Author

sjau commented Aug 28, 2018

@Mic92

Yes, works fine through the browser. Didn't check with the plex app.

LnL7
LnL7 suggested changes Aug 28, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the Plex Pass version, we can't include that in nixpkgs. If you want to use this version yourself you'll have to override it in an overlay.

See 5697295

@LnL7
Copy link
Member

LnL7 commented Aug 28, 2018

I have something like this in my configuration.nix to use a custom version instead of the default.

{ config, lib, pkgs, ... }:
{
  nixpkgs.overlays = [ 
    (self: super: 
    {
      plex = super.plex.overrideAttrs (drv: rec { 
        name = "plex-${version}";
        version = "0.0.0";
        src = super.fetchurl { 
          url = "https://downloads.plex.tv/plex-media-server/${version}.0000-000000000/plexmediaserver-0.0.0.0000-000000000.x86_64.rpm";
          sha256 = "0000000000000000000000000000000000000000000000000000";
        };
      });
    })
  ];
}

@LnL7 LnL7 closed this Aug 28, 2018
@sjau
Copy link
Author

sjau commented Aug 29, 2018

I still fail to see the issue. How is plex pass related to this?

@LnL7
Copy link
Member

LnL7 commented Aug 29, 2018

1.13.5 is the latest version that's publicly available

screen shot 2018-08-29 at 08 18 57

@sjau
Copy link
Author

sjau commented Aug 29, 2018

Interesting, you should reload your cache:

plex

@LnL7
Copy link
Member

LnL7 commented Aug 29, 2018

No, I disabled the Plex Pass toggle on the left.

@sjau
Copy link
Author

sjau commented Aug 29, 2018

I see. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjau @Mic92 @LnL7 @GrahamcOfBorg