Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twitterBootstrap: v2 -> v3 #45704

Merged
merged 1 commit into from Aug 28, 2018
Merged

twitterBootstrap: v2 -> v3 #45704

merged 1 commit into from Aug 28, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 28, 2018

cc @Profpatsch

v2 no longer compiles and is ancient

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
twitterBootstrap: v2 -> v3
1b09d06 
cc @Profpatsch

v2 no longer compiles and is ancient
@Mic92
Copy link
Member Author

Mic92 commented Aug 28, 2018

Also I don't see why nixpkgs should have packages like this.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: twitterBootstrap

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qqql3zs7fcr6yz71jrxsy1hvg0b455wh-bootstrap-3.3.7
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/qqql3zs7fcr6yz71jrxsy1hvg0b455wh-bootstrap-3.3.7
checking for references to /build in /nix/store/qqql3zs7fcr6yz71jrxsy1hvg0b455wh-bootstrap-3.3.7...
/nix/store/qqql3zs7fcr6yz71jrxsy1hvg0b455wh-bootstrap-3.3.7

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: twitterBootstrap

Partial log (click to expand)

source root is bootstrap-3.3.7-dist
setting SOURCE_DATE_EPOCH to timestamp 1469462010 of file bootstrap-3.3.7-dist/js/npm.js
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/fy0qkn1kc8sx0rds0fzf3apicl961is1-bootstrap-3.3.7
/nix/store/fy0qkn1kc8sx0rds0fzf3apicl961is1-bootstrap-3.3.7

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: twitterBootstrap

Partial log (click to expand)

these paths will be fetched (0.23 MiB download, 1.57 MiB unpacked):
  /nix/store/gqga08zgl1gx1r34g1mg77y0qqa2656z-bootstrap-3.3.7
copying path '/nix/store/gqga08zgl1gx1r34g1mg77y0qqa2656z-bootstrap-3.3.7' from 'https://cache.nixos.org'...
/nix/store/gqga08zgl1gx1r34g1mg77y0qqa2656z-bootstrap-3.3.7

@Mic92 Mic92 merged commit 6225ec0 into NixOS:master Aug 28, 2018
@Mic92 Mic92 deleted the bootstrap branch August 28, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @Profpatsch