Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e5af203a8719
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6a0a12a92163
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 26, 2018

  1. nginx: use a compression level of 5 in recommended configuration 

    While there is little gain of space to use a compression level of 9,
the CPU usage is significant. Many experiments point to use something
between 4 and 6. For example:

 - https://mjanja.ch/2015/03/finding-the-nginx-gzip_comp_level-sweet-spot/
 - https://github.com/h5bp/server-configs-nginx/blob/3bda5b93edba147d51760e900c2079828a7dc274/nginx.conf#L93
    @vincentbernat
    vincentbernat committed Aug 26, 2018

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    Moser-ss Stephane Moser
    GPG key ID: 51EA3CB018868B76
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    06a5fb2 View commit details

  2. nginx: add more gzipped MIME types 

    The additions are:

 - image/svg+xml for SVG images
 - application/atom+xml for Atom feeds

These types are also present in mime.types. For better readability,
the list is sorted and formatted with one type per line.
    @vincentbernat
    vincentbernat committed Aug 26, 2018

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    Moser-ss Stephane Moser
    GPG key ID: D8EC4CC760EEE98B
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    bd075eb View commit details

Commits on Aug 28, 2018

  1. Merge pull request #45659 from vincentbernat/fix/nginx-gzip 

    Small nginx tweaks
    @Mic92
    Mic92 authored Aug 28, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    6a0a12a View commit details
Showing with 12 additions and 2 deletions.
  1. +12 −2 nixos/modules/services/web-servers/nginx/default.nix
14 changes: 12 additions & 2 deletions nixos/modules/services/web-servers/nginx/default.nix
View file
Original file line number Diff line number Diff line change
@@ -92,8 +92,18 @@ let
gzip on;
gzip_disable "msie6";
gzip_proxied any;
gzip_comp_level 9;
gzip_types text/plain text/css application/json application/javascript text/xml application/xml application/xml+rss text/javascript;
gzip_comp_level 5;
gzip_types
application/atom+xml
application/javascript
application/json
application/xml
application/xml+rss
image/svg+xml
text/css
text/javascript
text/plain
text/xml;
gzip_vary on;
''}