Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the filename on unsupported shebang error #45698

Merged
merged 1 commit into from Sep 10, 2018
Merged

Show the filename on unsupported shebang error #45698

merged 1 commit into from Sep 10, 2018

Conversation

kamilchm
Copy link
Member

Motivation for this change

Simplifies debugging packages with large set of scripts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kamilchm kamilchm changed the title Show the filename on unsupported shebang error. Show the filename on unsupported shebang error Aug 28, 2018
kamilchm referenced this pull request Aug 28, 2018
@bjornfor @peti
patchShebangs: rewrite ".../bin/env python" to /nix/store/.../python
7bf209d 
Currently "/usr/bin/env python" is rewritten to "/nix/store/.../env
python". That doesn't really improve anything because the interpreter
still have to be located in $PATH at runtime. The result is that many
nix package expressions do .../bin/env fixup themselves.

Instead of everyone having to do this patching locally, add the
functionality to the standard environment patchShebangs function so that
everyone can benefit.
@Mic92
Copy link
Member

Mic92 commented Aug 28, 2018

This should go to staging.

@kamilchm
Copy link
Member Author

You mean the staging branch?

@Ericson2314
Copy link
Member

Ericson2314 commented Aug 29, 2018 •
edited

Yes, the staging branch.

@kamilchm kamilchm changed the base branch from master to staging August 29, 2018 19:45
@kamilchm kamilchm changed the base branch from staging to master August 29, 2018 19:45
@kamilchm
patch-shebangs: filename on unsupported shebang
383de74 
Show the filename on unsupported shebang error.
Simplifies debugging packages with large set of scripts.
@kamilchm kamilchm force-pushed the filename-in-usnupported-shebang-error branch from cead975 to 383de74 Compare August 29, 2018 19:47
@kamilchm kamilchm requested a review from FRidh as a code owner August 29, 2018 19:47
@kamilchm kamilchm changed the base branch from master to staging August 29, 2018 19:48
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 6.topic: xfce The Xfce Desktop Environment 8.has: documentation 8.has: clean-up 8.has: package (new) and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 6.topic: xfce The Xfce Desktop Environment 8.has: documentation labels Aug 29, 2018
@kamilchm
Copy link
Member Author

kamilchm commented Sep 3, 2018

@Ericson2314 target changed to staging

@oxij
Copy link
Member

oxij commented Sep 5, 2018 via email

@matthewbauer matthewbauer merged commit e258c8d into NixOS:staging Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kamilchm @Mic92 @Ericson2314 @oxij @matthewbauer @GrahamcOfBorg