Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop libnm-gtk #45707

Merged
merged 8 commits into from Aug 28, 2018
Merged

Drop libnm-gtk #45707

merged 8 commits into from Aug 28, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 28, 2018

Motivation for this change

It is not used for anything any more (it was used by GNOME 2 control center).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: networkmanager-fortisslvpn, networkmanager-iodine, networkmanager-l2tp, networkmanager-openvpn, networkmanager-vpnc, networkmanager_strongswan, networkmanagerapplet

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: networkmanager-fortisslvpn, networkmanager-iodine, networkmanager-l2tp, networkmanager-openvpn, networkmanager-vpnc, networkmanager_strongswan, networkmanagerapplet

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/ybdsb07clqb05889hndrv9pdyx6j5xv7-NetworkManager-vpnc-gnome-1.2.6/lib  /nix/store/ybdsb07clqb05889hndrv9pdyx6j5xv7-NetworkManager-vpnc-gnome-1.2.6/libexec
patching script interpreter paths in /nix/store/ybdsb07clqb05889hndrv9pdyx6j5xv7-NetworkManager-vpnc-gnome-1.2.6
/nix/store/ppm4k22lxnrz0k2jcxi0fgd24r9l3nbi-NetworkManager-fortisslvpn-gnome-1.2.8
checking for references to /build in /nix/store/ybdsb07clqb05889hndrv9pdyx6j5xv7-NetworkManager-vpnc-gnome-1.2.6...
/nix/store/knz30hkv7ia791cfff378cbh0m0sfg07-NetworkManager-iodine-gnome-1.2.0
/nix/store/8g0ilyrb3jyg1r8klxqxvk5labikfd39-NetworkManager-l2tp-gnome-1.2.10
/nix/store/166lwi12brx9paplz6787ywzri8qayf0-NetworkManager-openvpn-gnome-1.8.4
/nix/store/ybdsb07clqb05889hndrv9pdyx6j5xv7-NetworkManager-vpnc-gnome-1.2.6
/nix/store/00v72m72vqranbnbp4pkkjngx5hw8ln2-NetworkManager-strongswan-1.4.4
/nix/store/bxfqxkknsadrzxvxq7xvxcj5jv2jbrxb-network-manager-applet-1.8.16

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: networkmanager-fortisslvpn, networkmanager-iodine, networkmanager-l2tp, networkmanager-openvpn, networkmanager-vpnc, networkmanager_strongswan, networkmanagerapplet

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/44b1md65ggdxldysyxy9gqvjjji2233v-NetworkManager-openvpn-gnome-1.8.4/lib  /nix/store/44b1md65ggdxldysyxy9gqvjjji2233v-NetworkManager-openvpn-gnome-1.8.4/libexec
patching script interpreter paths in /nix/store/44b1md65ggdxldysyxy9gqvjjji2233v-NetworkManager-openvpn-gnome-1.8.4
checking for references to /build in /nix/store/44b1md65ggdxldysyxy9gqvjjji2233v-NetworkManager-openvpn-gnome-1.8.4...
/nix/store/g9xx5zpfj635rl75rnwmjvjra372dgrb-NetworkManager-fortisslvpn-gnome-1.2.8
/nix/store/rj12xlg88k91i2n6wxj54hasslsrf4yp-NetworkManager-iodine-gnome-1.2.0
/nix/store/xmkxagvvypkpylh32z72acy94211b0vk-NetworkManager-l2tp-gnome-1.2.10
/nix/store/44b1md65ggdxldysyxy9gqvjjji2233v-NetworkManager-openvpn-gnome-1.8.4
/nix/store/k2df8jmq6sfhfgmgqyq8a340qbbc3vf7-NetworkManager-vpnc-gnome-1.2.6
/nix/store/1q3m3zhsz89pc7a19f746bzp4mrx7xj9-NetworkManager-strongswan-1.4.4
/nix/store/cksfqvk7pqqi0mfldihmlk86nmhs1pzi-network-manager-applet-1.8.16

@Mic92
Copy link
Member

Mic92 commented Aug 28, 2018

I suppose mate also does not use this?

@worldofpeace
Copy link
Contributor

This wouldn't affect nm-connection-editor right?

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 28, 2018 •
edited

@worldofpeace Nope, nm-connection-editor uses libnma (modern version of libnm-gtk not using libnm-glib).

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 28, 2018

@Mic92 mate does not seem to depend on networkmanagerapplet. If it requires nm-gtk optionally, it is not currently enabled, so removing nm-gtk should not matter. And if mate maintainers wanted to enable it, it would break with next nm-applet release which will likely remove nm-gtk.

@jtojnar jtojnar merged commit bbe620f into NixOS:master Aug 28, 2018
@jerith666
Copy link
Contributor

I just updated from 0832208 to ca2ba44 and my vpnc-based vpn stopped working. The error was: Error: Connection activation failed: The VPN service 'org.freedesktop.NetworkManager.vpnc' was not installed.

I reverted this merge and also 9efc9b5, and it went back to working.

@jtojnar jtojnar deleted the drop-nm-gtk branch September 13, 2018 01:40
@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 13, 2018

@jerith666 try #46201

@jerith666
Copy link
Contributor

Yes, I just found that too! Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jtojnar @GrahamcOfBorg @Mic92 @worldofpeace @jerith666