nixos: xserver.displayManager: use slim for automatic logins #46396

oxij · 2018-09-08T21:19:12Z

Motivation for this change

lightdm is not that light for automatic logins: it runs two processes three threads each (while slim runs one of each) all of which stay in memory even after login is finished. Meanwhile, auto users usually want the display manager to get out of their way, not to pollute their system with six useless threads. Moreover, the closure size of slim+theme in its default config in NixOS is 53M, while the similar closure size of lightdm+greeter+theme is 254M.

Things done

This is how it was before display-managers: make lightdm the default #30890.
Writing this from a system with this applied.

`lightdm` is not that light for automatic logins: it runs two processes three threads each (while slim runs one of each) all of which stay in memory even after login is finished. Meanwhile, `auto` users usually want the display manager to get out of their way, not to pollute their system with six useless threads. Moreover, the closure size of slim+theme in its default config in NixOS is 53M, while the similar closure size of lightdm+greeter+theme is 254M. This reverts a part of commit fc035da.

This reverts commit 5f72169.

This reverts commit 7e9bd2d. No longer needed after the previous commit.

xeji · 2018-09-08T21:31:12Z

If this is merged (I don't have a strong opinion about it), it should be backported to 18.09 because it can be a pain to debug/fix NixOS tests if the basic test setup is different between master and 18.09.

matthewbauer · 2018-09-08T22:53:03Z

nixos/modules/services/x11/display-managers/auto.nix

-        user = cfg.user;
-      };
+      autoLogin = true;
+      defaultUser = cfg.user;


Not an issue with this PR but we should standardize the settings so autoLogin works the same regardless of DM.

oxij · 2018-09-23T14:07:24Z

Ping. I still think this need to be merged. Let me remind you that this also fixes

- Normally I `exec xmonad` at the end of `.xsession`. With `lightdm` exiting `xmonad` brings the system into an unusable state, `lightdm` just keeps running, showing its background window as if nothing happened, and you have to login in another tty and restart `display-manager` manually to get anything done.

mentioned in #30890 (comment) Also of note since the switch to `lightdm` are the following discourse topics https://discourse.nixos.org/t/stuck-with-a-failing-lightdm/930/1 and https://discourse.nixos.org/t/how-to-upgrade-from-18-03-to-18-09/933/1 Both have "`lightdm` doesn't works until you rebuild and reboot your system several times" symptoms, no idea why or what, but looks interesting.

wizeman · 2019-05-16T03:21:32Z

This PR also fixes another bug: if the desktop manager crashes, it causes lightdm to restart but it won't auto-login again, therefore getting stuck at the 'enter password' screen.
I was observing this behavior with Kodi, but when I tried applying this PR to my config, the bug is fixed.

samueldr · 2019-05-16T14:12:50Z

The "bug" about lightdm not doing auto-login on crash (haven't checked, but I suspect it's when the session exits non-zero) is imo not a bug. This reduces the risk of a broken session causing a tight loop with the display manager logging-in → starting session → crashing → restarting, in those situations switching to a VT could be problematic since AFAIK most DMs will throw away the X server and start a new one, thus pulling the user back to the looping VT.

I do not know how to approach this appropriately, but maybe some tip in the documentation that for unattended autologin slim would be more appropriate due to that behaviour, while the behaviour from lightdm is preferred on an end-user's machine.

wizeman · 2019-05-16T14:41:51Z

@samueldr IMO your scenario is more appropriately handled by lightdm exiting with a non-zero status (assuming the DM exited with a non-zero status) and letting systemd auto-restart the display-manager service. This would probably work better because systemd already has in-built mechanisms to prevent a service from entering an infinite start-fail loop (after a few tries, systemd stops trying to restart the service when the service fails relatively quickly after being restarted).

This might be what slim does already, although I haven't verified it yet.

wizeman · 2019-05-16T19:33:15Z

Ok, I have verified that slim behaves exactly as I mentioned in my comment above, which is the behavior I would expect and prevents the infinite start-fail loop in case the desktop manager keeps crashing at startup.

To check this behavior, I have performed a bunch of pkill -9 kodi-x11 in a row (kodi-x11 is the process name of the desktop manager I am using) on a machine with this PR, and I confirm that systemd stopped restarting the display-manager service (i.e. the X server) after I killed kodi 3 times in less than one minute.

Note that systemd already does this by default, but the "stop restarting" behavior is also explicitly fine-tuned here:

nixpkgs/nixos/modules/services/x11/xserver.nix

Lines 684 to 687 in 3223534

    
           # Stop restarting if the display manager stops (crashes) 2 times 
        
           # in one minute. Starting X typically takes 3-4s. 
        
           StartLimitInterval = "30s"; 
        
           StartLimitBurst = "3";

To be clear, note that lightdm currently does not behave like this -- instead, if the desktop manager crashes lightdm will simply go back to a login screen even though auto-login is enabled, which is not the behavior I would expect (principle of least surprise?).

So to summarize, IMHO I think this PR fixes a bunch of issues with auto-login and I think it should either be merged or lightdm should be fixed accordingly.

samueldr · 2019-05-17T01:39:02Z

Looks like lightdm has an open issue.

fgaz · 2019-12-06T15:54:53Z

Slim was removed in #73251, I think this can be closed

oxij · 2019-12-09T04:43:55Z

No, the correct way now is to revert #73251 and then merge this. The OP issue still persists.

This reverts commit 4583e29, reversing changes made to d6fa540. The fact that SLiM is not officially actively maintained is not a good reason to remove it. It works, and, in some instances, like automatic logins, it is the only thing that actually works. See NixOS#46396 and NixOS#30890 (comment).

stale · 2020-06-06T06:45:18Z

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the related code and @ mention them in a comment.
Ask on the NixOS Discourse.
Ask on the #nixos channel on irc.freenode.net.

stale · 2021-04-07T02:54:05Z

I marked this as stale due to inactivity. → More info

oxij added 3 commits September 8, 2018 21:13

Revert "nixos/displayManagers/auto: allow root auto-login"

1c6f3cb

This reverts commit 5f72169.

Revert "nixos/tests/flatpak: explicitly disable gdm to fix eval"

5072f73

This reverts commit 7e9bd2d. No longer needed after the previous commit.

oxij changed the title ~~Nixos/slim for auto~~ nixos: xserver.displayManager: use slim for automatic logins Sep 8, 2018

oxij mentioned this pull request Sep 8, 2018

display-managers: make lightdm the default #30890

Merged

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Sep 8, 2018

matthewbauer reviewed Sep 8, 2018

View reviewed changes

oxij mentioned this pull request Oct 4, 2018

nixos/display-managers/startx: init #47773

Merged

1 task

oxij mentioned this pull request Dec 9, 2019

nixos/slim: remove #73251

Merged

10 tasks

oxij mentioned this pull request Dec 9, 2019

nixos/slim: reintroduce #75389

Closed

3 tasks

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2020

ryantm added the 2.status: merge conflict label Oct 3, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2021

Artturin closed this Apr 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixos: xserver.displayManager: use slim for automatic logins #46396

nixos: xserver.displayManager: use slim for automatic logins #46396

oxij commented Sep 8, 2018

xeji commented Sep 8, 2018

matthewbauer Sep 8, 2018

oxij commented Sep 23, 2018 via email

wizeman commented May 16, 2019

samueldr commented May 16, 2019

wizeman commented May 16, 2019 •

edited

wizeman commented May 16, 2019

samueldr commented May 17, 2019

fgaz commented Dec 6, 2019

oxij commented Dec 9, 2019 via email

stale bot commented Jun 6, 2020

stale bot commented Apr 7, 2021

nixos: xserver.displayManager: use slim for automatic logins #46396

nixos: xserver.displayManager: use slim for automatic logins #46396

Conversation

oxij commented Sep 8, 2018

Motivation for this change

Things done

xeji commented Sep 8, 2018

matthewbauer Sep 8, 2018

Choose a reason for hiding this comment

oxij commented Sep 23, 2018 via email

wizeman commented May 16, 2019

samueldr commented May 16, 2019

wizeman commented May 16, 2019 • edited

wizeman commented May 16, 2019

samueldr commented May 17, 2019

fgaz commented Dec 6, 2019

oxij commented Dec 9, 2019 via email

stale bot commented Jun 6, 2020

stale bot commented Apr 7, 2021

wizeman commented May 16, 2019 •

edited