vim-plugins: rewrite updater #46394
Merged
vim-plugins: rewrite updater #46394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
vim-updater
branch
2 times, most recently
from
f285b22
to
5f64920
Compare
|
nix-review is happy with the new version. |
|
I had a feeling about this when seeing 182f1fc. 😃 |
|
It is much more fun to add vim plugins now. |
Mic92
force-pushed
the
vim-updater
branch
2 times, most recently
from
649ea94
to
555b7a3
Compare
|
Now with documentation! I will backport the first commit, where I extended the vim plugin documentation. |
A new python script has been added to replace the aged viml-based updater. The new updater has the following advantages: - use rss feeds to check for updates quicker - parallel downloads & better caching - uses proper override mechanism instead of text substitution - update generated files in-place instead of having to insert updated plugins manually Automatically reading `dependencies` from the plugins directory has been not re-implemented. This has been mostly been used by Mark Weber's plugins, which seem to no longer receive regular updates. This could be implemented in future as required.
|
How can the |
|
Sorry after a git-reset I accidentally did not include this file again. I added it in 8ccdd29 |
9 tasks
Mic92
added a commit
to Mic92/nixpkgs
that referenced
this pull request
Sep 23, 2018
This is a left-over from NixOS#46394 We no longer use this.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new python script has been added to replace the aged viml-based
updater. The new updater has the following advantages:
Automatically adding plugin
dependenciesbased on plugin metadata has beennot re-implemented in this updater.
This mechanism has been mostly been used by Mark Weber's plugins, which seem to
no longer receive regular updates.
This could be implemented in future as required.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)