Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyre: 0.9.0 -> 0.11.0 #46393

Merged
merged 1 commit into from Sep 9, 2018
Merged

pyre: 0.9.0 -> 0.11.0 #46393

merged 1 commit into from Sep 9, 2018

Conversation

teh
Copy link
Contributor

@teh teh commented Sep 8, 2018

Motivation for this change

The ocaml pyre binary can't really be used standalone any more, so this wraps into the full python binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@teh teh force-pushed the master branch 2 times, most recently from 0337917 to d309f80 Compare September 8, 2018 21:20
Mic92
Mic92 reviewed Sep 9, 2018
View reviewed changes
pkgs/development/tools/pyre/default.nix
@@ -41,13 +49,15 @@ in stdenv.mkDerivation {
export HOME=.

# "external" because https://github.com/facebook/pyre-check/pull/8/files
sed "s/%VERSION%/external ${version}/" Makefile.template > Makefile
sed "s/%VERSION%/external ${pyre-version}/" Makefile.template > Makefile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not found %VERSION% in this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in c4d8d4b

@Mic92
Copy link
Member

Mic92 commented Sep 9, 2018

@GrahamcOfBorg build pyre

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pyre

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pyre

Partial log (click to expand)

-> stderr:
Fatal error: exception (runtime-lib/runtime.ml.E "comparison failed"
  ((switch true) vs (switch false) (Loc src/config/discover.ml:205:15)))
Raised at file "src/configurator.ml", line 511, characters 13-22
Called from file "src/config/discover.ml", line 136, characters 2-1023
make: *** [Makefile:5: default] Error 1
builder for '/nix/store/i0if6p886q14jak4v7r0wncq9nrny9rw-ocaml4.06.1-core-0.11.2.drv' failed with exit code 2
cannot build derivation '/nix/store/zb538q8czvp8wx9nfzz5j4yi318p4q9r-pyre-0.0.11.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/afjif7357sl7czr2670sn9waarx0zx71-pyre-check-0.0.11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/afjif7357sl7czr2670sn9waarx0zx71-pyre-check-0.0.11.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pyre

Partial log (click to expand)

Successfully installed pyre-check-0.0.11
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z5hh13wv8hrlpa8zlvhnrj6hia7llkcw-pyre-check-0.0.11
shrinking /nix/store/z5hh13wv8hrlpa8zlvhnrj6hia7llkcw-pyre-check-0.0.11/bin/pyre.bin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z5hh13wv8hrlpa8zlvhnrj6hia7llkcw-pyre-check-0.0.11/lib  /nix/store/z5hh13wv8hrlpa8zlvhnrj6hia7llkcw-pyre-check-0.0.11/bin
patching script interpreter paths in /nix/store/z5hh13wv8hrlpa8zlvhnrj6hia7llkcw-pyre-check-0.0.11
checking for references to /build in /nix/store/z5hh13wv8hrlpa8zlvhnrj6hia7llkcw-pyre-check-0.0.11...
wrapping `/nix/store/z5hh13wv8hrlpa8zlvhnrj6hia7llkcw-pyre-check-0.0.11/bin/pyre'...

@Mic92 Mic92 merged commit b989e6f into NixOS:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teh @Mic92 @GrahamcOfBorg