Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pycaption: fix build #46356

Merged
merged 1 commit into from Sep 8, 2018
Merged

pythonPackages.pycaption: fix build #46356

merged 1 commit into from Sep 8, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 8, 2018 •
edited

Motivation for this change

The beaitufulsoup4 package distributed by nixpkgs is now at 4.6.3.

Additionally it fixes gnomecaption which depends on the broken
pycaption package.

See https://hydra.nixos.org/build/81000247
See https://hydra.nixos.org/build/80723223

Addresses #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
pythonPackages.pycaption: fix build
7ff04b1 
The `beaitufulsoup4` package distributed by `nixpkgs` is now at `4.6.3`.

Additionally it fixes `gnomecaption` which depends on the broken
`pycaption` package.

See https://hydra.nixos.org/build/81000247
See https://hydra.nixos.org/build/80723223

Addresses NixOS#45960
@Ma27 Ma27 requested a review from FRidh as a code owner September 8, 2018 08:42
@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

@GrahamcOfBorg build python36Packages.pycaption gnomecaption

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.pycaption

The following builds were skipped because they don't evaluate on aarch64-linux: gnomecaption

Partial log (click to expand)

Installing collected packages: pycaption
Successfully installed pycaption-1.0.1
/build/pycaption-1.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/439pqh5mmzx143wv6yfysnygxffzfprv-python3.6-pycaption-1.0.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/439pqh5mmzx143wv6yfysnygxffzfprv-python3.6-pycaption-1.0.1/lib
patching script interpreter paths in /nix/store/439pqh5mmzx143wv6yfysnygxffzfprv-python3.6-pycaption-1.0.1
checking for references to /build in /nix/store/439pqh5mmzx143wv6yfysnygxffzfprv-python3.6-pycaption-1.0.1...
/nix/store/439pqh5mmzx143wv6yfysnygxffzfprv-python3.6-pycaption-1.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.pycaption

The following builds were skipped because they don't evaluate on x86_64-linux: gnomecaption

Partial log (click to expand)

Installing collected packages: pycaption
Successfully installed pycaption-1.0.1
/build/pycaption-1.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s9jgm7xk0q5gbvsznp92hbxp1nf88yjy-python3.6-pycaption-1.0.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s9jgm7xk0q5gbvsznp92hbxp1nf88yjy-python3.6-pycaption-1.0.1/lib
patching script interpreter paths in /nix/store/s9jgm7xk0q5gbvsznp92hbxp1nf88yjy-python3.6-pycaption-1.0.1
checking for references to /build in /nix/store/s9jgm7xk0q5gbvsznp92hbxp1nf88yjy-python3.6-pycaption-1.0.1...
/nix/store/s9jgm7xk0q5gbvsznp92hbxp1nf88yjy-python3.6-pycaption-1.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.pycaption

The following builds were skipped because they don't evaluate on x86_64-darwin: gnomecaption

Partial log (click to expand)

Requirement already satisfied: six>=1.9.0 in /nix/store/lzq4ax4glj09dvnipwslav7fxvggcq4s-python3.6-six-1.11.0/lib/python3.6/site-packages (from pycaption==1.0.1) (1.11.0)
Requirement already satisfied: cssutils>=0.9.10 in /nix/store/vnwzhcpmra1m8bv4cr5f79lvr4n2jz7x-python3.6-cssutils-1.0.2/lib/python3.6/site-packages (from pycaption==1.0.1) (1.0.2)
Installing collected packages: pycaption
Successfully installed pycaption-1.0.1
/private/tmp/nix-build-python3.6-pycaption-1.0.1.drv-0/pycaption-1.0.1
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ma0xsk3iqaj3mqvw9dj1i2pakykb95ri-python3.6-pycaption-1.0.1/lib
patching script interpreter paths in /nix/store/ma0xsk3iqaj3mqvw9dj1i2pakykb95ri-python3.6-pycaption-1.0.1
/nix/store/ma0xsk3iqaj3mqvw9dj1i2pakykb95ri-python3.6-pycaption-1.0.1

@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

😄 I copied gnomecaption from the PR description, but it's actually gnomecast
@GrahamcOfBorg build gnomecast

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnomecast

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnomecast

Partial log (click to expand)

writing top-level names to gnomecast.egg-info/top_level.txt
reading manifest file 'gnomecast.egg-info/SOURCES.txt'
writing manifest file 'gnomecast.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/dzjrh58ys2mf8hj80ap9pinzpy5mm371-gnomecast-1.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnomecast

Partial log (click to expand)

writing top-level names to gnomecast.egg-info/top_level.txt
reading manifest file 'gnomecast.egg-info/SOURCES.txt'
writing manifest file 'gnomecast.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/yqkpm37sd5ivp4jka157mrz70kk788fs-gnomecast-1.4.0

@xeji xeji merged commit a02002d into NixOS:master Sep 8, 2018
@Ma27 Ma27 deleted the fix-pycaption branch September 8, 2018 09:49
xeji pushed a commit that referenced this pull request Sep 8, 2018
@Ma27 @xeji
pythonPackages.pycaption: fix build (#46356)
4eaa7ef 
The `beaitufulsoup4` package distributed by `nixpkgs` is now at `4.6.3`.

Additionally it fixes `gnomecaption` which depends on the broken
`pycaption` package.

See https://hydra.nixos.org/build/81000247
See https://hydra.nixos.org/build/80723223

Addresses #45960

(cherry picked from commit a02002d)
@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

backported: 4eaa7ef

@Ma27
Copy link
Member Author

Ma27 commented Sep 8, 2018

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @xeji @GrahamcOfBorg