Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

altcoins.btc1d: fix darwin build #46398

Merged
merged 1 commit into from Sep 9, 2018
Merged

altcoins.btc1d: fix darwin build #46398

merged 1 commit into from Sep 9, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 8, 2018

The gui build doesn't work yet.

Motivation for this change

Only hexdump was needed from utillinux which is also available on darwin
through the unixtools meta package.

/cc ZHF #45961

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
altcoins.btc1: fix darwin build
35bb599 
Only hexdump was needed from utillinux which is also available on darwin
through the unixtools meta package.

/cc ZHF NixOS#45961
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

@GrahamcOfBorg build altcoins.btc1d altcoins.btc1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: altcoins.btc1d, altcoins.btc1

Partial log (click to expand)

/nix/store/l1h4rqsk8i115mhcxwhmqwax78z1yca2-bit1d-1.15.1
/nix/store/l1h4rqsk8i115mhcxwhmqwax78z1yca2-bit1d-1.15.1

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: altcoins.btc1d, altcoins.btc1

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/03dfab37hr2z2q2aqw79lfifxc3jz6wb-bit1-1.15.1
shrinking /nix/store/03dfab37hr2z2q2aqw79lfifxc3jz6wb-bit1-1.15.1/lib/libbitcoinconsensus.so.0.0.0
shrinking /nix/store/03dfab37hr2z2q2aqw79lfifxc3jz6wb-bit1-1.15.1/bin/test_bitcoin-qt
shrinking /nix/store/03dfab37hr2z2q2aqw79lfifxc3jz6wb-bit1-1.15.1/bin/test_bitcoin
shrinking /nix/store/03dfab37hr2z2q2aqw79lfifxc3jz6wb-bit1-1.15.1/bin/bitcoin-cli
shrinking /nix/store/03dfab37hr2z2q2aqw79lfifxc3jz6wb-bit1-1.15.1/bin/bitcoind
building of '/nix/store/wxziibhisskfxmavyv0wgfpwj0inm2jk-bit1-1.15.1.drv' timed out after 1800 seconds
error: build of '/nix/store/wxziibhisskfxmavyv0wgfpwj0inm2jk-bit1-1.15.1.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: altcoins.btc1d, altcoins.btc1

Partial log (click to expand)

  CXX      test/test_bitcoin-dbwrapper_tests.o
  CXX      test/test_bitcoin-miner_tests.o
test/miner_tests.cpp:34:2: warning: #warning hack [-Wcpp]
 #warning hack
  ^~~~~~~
  CXX      test/test_bitcoin-main_tests.o
building of '/nix/store/38acf6rdx0jgq3jvvzhhin82v55a2np2-bit1d-1.15.1.drv' timed out after 3600 seconds
  CXX      test/test_bitcoin-mempool_tests.o
building of '/nix/store/ld67flc9q8kkyaky7kxv43bvxqgalnl8-bit1-1.15.1.drv' timed out after 3600 seconds
error: build of '/nix/store/38acf6rdx0jgq3jvvzhhin82v55a2np2-bit1d-1.15.1.drv', '/nix/store/ld67flc9q8kkyaky7kxv43bvxqgalnl8-bit1-1.15.1.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

build checked locally for x86_64-linux.

@xeji xeji merged commit 4e282e2 into NixOS:master Sep 9, 2018
xeji pushed a commit that referenced this pull request Sep 9, 2018
@LnL7 @xeji
altcoins.btc1: fix darwin build (#46398)
b68bfbc 
Only hexdump was needed from utillinux which is also available on darwin
through the unixtools meta package.

(cherry picked from commit 4e282e2)
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

backported: b68bfbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @xeji @GrahamcOfBorg