Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: release.nix: add configuration parameter #46400

Merged
merged 3 commits into from Sep 30, 2018
Merged

nixos: release.nix: add configuration parameter #46400

merged 3 commits into from Sep 30, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Sep 8, 2018

Motivation for this change

I wanted to build stuff in release.nix with doCheckByDefault of #39464 enabled.

Things done
  • It works as expected when needed.
  • Noop by default.

@oxij
Copy link
Member Author

oxij commented Sep 23, 2018

ping?

@oxij
Copy link
Member Author

oxij commented Sep 24, 2018

ping ping?

@oxij
Copy link
Member Author

oxij commented Sep 30, 2018

@vcunat @xeji @7c6f434c ping^3

xeji
xeji approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can see no downside.

@xeji xeji merged commit 9afdcb2 into NixOS:master Sep 30, 2018
@oxij oxij deleted the nixos/release-config branch November 18, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @xeji @GrahamcOfBorg