Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bullet: fix darwin build #46422

Merged
merged 1 commit into from Sep 10, 2018
Merged

bullet: fix darwin build #46422

merged 1 commit into from Sep 10, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 9, 2018

Motivation for this change

The examples fail with an opengl related issue:

Undefined symbols for architecture x86_64:
  "SimpleOpenGL3App::SimpleOpenGL3App(char const*, int, int, bool)", referenced from:
      _main in main_opengl_single_example.o
  "_useShadowMap", referenced from:
      GL_ShapeDrawer::drawScene(btDiscreteDynamicsWorld const*, bool, int) in GL_ShapeDrawer.o
ld: symbol(s) not found for architecture x86_64

And the tests need an extra dependencly, possibley related to
bulletphysics/bullet3#819

ld: library not found for -lBussIK

/cc ZHF #45961

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
bullet: fix darwin build
939debc 
The examples fail with an opengl related issue:

    Undefined symbols for architecture x86_64:
      "SimpleOpenGL3App::SimpleOpenGL3App(char const*, int, int, bool)", referenced from:
          _main in main_opengl_single_example.o
      "_useShadowMap", referenced from:
          GL_ShapeDrawer::drawScene(btDiscreteDynamicsWorld const*, bool, int) in GL_ShapeDrawer.o
    ld: symbol(s) not found for architecture x86_64

And the tests need an extra dependencly, possibley related to
bulletphysics/bullet3#819

    ld: library not found for -lBussIK

/cc ZHF NixOS#45961
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Sep 9, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 9, 2018

@GrahamcOfBorg build bullet

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bullet

Partial log (click to expand)

/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libBullet2FileLoader.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libBullet3Collision.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libBullet3Geometry.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libBulletInverseDynamicsUtils.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libLinearMath.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libBulletSoftBody.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libBulletFileLoader.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libGIMPACTUtils.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libBulletXmlWorldImporter.2.87.dylib: fixing dylib
/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87/lib/libBulletCollision.2.87.dylib: fixing dylib

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bullet

Partial log (click to expand)

shrinking /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87/lib/libConvexDecomposition.so.2.87
shrinking /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87/lib/libBulletWorldImporter.so.2.87
shrinking /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87/lib/libBulletXmlWorldImporter.so.2.87
shrinking /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87/lib/libBulletFileLoader.so.2.87
shrinking /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87/lib/libBulletRobotics.so.2.87
shrinking /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87/lib/libBulletInverseDynamicsUtils.so.2.87
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87/lib
patching script interpreter paths in /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87
checking for references to /build in /nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bullet

Partial log (click to expand)

/nix/store/ajybgzqz9yqdr0ddcb41wm9j9qvnv7ni-bullet-2.87

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bullet

Partial log (click to expand)

/nix/store/yx5q4q70hgg1pmb8nrs1wfm4m8v0pqfs-bullet-2.87

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bullet

Partial log (click to expand)

shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBulletXmlWorldImporter.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libConvexDecomposition.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libHACD.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBullet3Collision.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBulletDynamics.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBulletFileLoader.so.2.87
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib
patching script interpreter paths in /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87
checking for references to /build in /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bullet

Partial log (click to expand)

shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBulletRobotics.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBulletWorldImporter.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBullet3Dynamics.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBullet3Common.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBulletSoftBody.so.2.87
shrinking /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib/libBulletXmlWorldImporter.so.2.87
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87/lib
patching script interpreter paths in /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87
checking for references to /build in /nix/store/cvi477nbp2i3nlz730ijr2qqrallbkwr-bullet-2.87...

@LnL7 LnL7 merged commit 189b861 into NixOS:master Sep 10, 2018
@LnL7 LnL7 deleted the darwin-bullet branch September 10, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @Mic92 @GrahamcOfBorg