Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mage: init at 1.7.1 #46407

Merged
merged 2 commits into from Nov 18, 2018
Merged

mage: init at 1.7.1 #46407

merged 2 commits into from Nov 18, 2018

Conversation

swdunlop
Copy link
Contributor

@swdunlop swdunlop commented Sep 8, 2018

Motivation for this change

add mage, a make-like tool using Go

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Sep 23, 2018
View reviewed changes
pkgs/development/tools/build-managers/mage/default.nix Outdated
subPackages = [ "." ];

src = fetchFromGitHub {
inherit rev;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use rev = version instead of declaring rev above.

pkgs/development/tools/build-managers/mage/default.nix Outdated

# ex: from pkgs/development/tools/dep/default.nix
# buildFlagsArray = ("-ldflags=-s -w -X main.commitHash=${rev} -X main.version=${version}");
buildFlagsArray = ("-ldflags=-X github.com/magefile/mage/mage.gitTag=${rev}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And use version here.

@c0bw3b c0bw3b changed the title mage: init at 1.2.4 mage: init at 1.7.1 Nov 18, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

@GrahamcOfBorg build mage

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mage

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ghz94488wan8z2rarm742lyc7s7w2cmg-mage-1.7.1-bin
shrinking /nix/store/ghz94488wan8z2rarm742lyc7s7w2cmg-mage-1.7.1-bin/bin/mage
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ghz94488wan8z2rarm742lyc7s7w2cmg-mage-1.7.1-bin/bin
patching script interpreter paths in /nix/store/ghz94488wan8z2rarm742lyc7s7w2cmg-mage-1.7.1-bin
checking for references to /build in /nix/store/ghz94488wan8z2rarm742lyc7s7w2cmg-mage-1.7.1-bin...
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/ghz94488wan8z2rarm742lyc7s7w2cmg-mage-1.7.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mage

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/xi34ywzf20kf7kq091ali3x9l4gmvhcf-mage-1.7.1-bin
shrinking /nix/store/xi34ywzf20kf7kq091ali3x9l4gmvhcf-mage-1.7.1-bin/bin/mage
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xi34ywzf20kf7kq091ali3x9l4gmvhcf-mage-1.7.1-bin/bin
patching script interpreter paths in /nix/store/xi34ywzf20kf7kq091ali3x9l4gmvhcf-mage-1.7.1-bin
checking for references to /build in /nix/store/xi34ywzf20kf7kq091ali3x9l4gmvhcf-mage-1.7.1-bin...
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/xi34ywzf20kf7kq091ali3x9l4gmvhcf-mage-1.7.1-bin

@c0bw3b c0bw3b merged commit 611ef59 into NixOS:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@swdunlop @c0bw3b @GrahamcOfBorg @nlewo