Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 68.0.3440.75 -> 69.0.3497.81 (18.03 backport) #46389

Merged
merged 1 commit into from Sep 9, 2018
Merged

chromium: 68.0.3440.75 -> 69.0.3497.81 (18.03 backport) #46389

merged 1 commit into from Sep 9, 2018

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Sep 8, 2018 •
edited

Motivation for this change

This is a backport of #46348 with private import of #46328, just for Chromium build.

We can't packport all gn changes to general package as it will trigger huge rebuild.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

CC @vcunat @bendlas @7c6f434c

@YorikSar
chromium: 68.0.3440.75 -> 69.0.3497.81 (18.03 backport)
ab193a6 
Import latest gn from NixOS#46328, just from Chromium build, since it will
trigger huge rebuild otherwise.
@7c6f434c 7c6f434c merged commit 36005e5 into NixOS:release-18.03 Sep 9, 2018
@YorikSar YorikSar deleted the update-chromium-18.03 branch June 8, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YorikSar @7c6f434c @GrahamcOfBorg