Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lidarr: init at 0.3.1.471 #46416

Closed
wants to merge 1 commit into from
Closed

lidarr: init at 0.3.1.471 #46416

wants to merge 1 commit into from

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 9, 2018

Motivation for this change

Fork of sonarr (as radarr) but for music instead of series and movies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: lidarr

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lidarr

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pb1gixslgn5ag3i3z6n5aciq2p8fjc5d-lidarr-0.3.1.471
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pb1gixslgn5ag3i3z6n5aciq2p8fjc5d-lidarr-0.3.1.471/bin
patching script interpreter paths in /nix/store/pb1gixslgn5ag3i3z6n5aciq2p8fjc5d-lidarr-0.3.1.471
checking for references to /build in /nix/store/pb1gixslgn5ag3i3z6n5aciq2p8fjc5d-lidarr-0.3.1.471...
/nix/store/pb1gixslgn5ag3i3z6n5aciq2p8fjc5d-lidarr-0.3.1.471

symphorien
symphorien reviewed Sep 9, 2018
View reviewed changes
nixos/modules/services/misc/lidarr.nix Outdated
mkdir -p /var/lib/lidarr/
}
chown -R lidarr:lidarr /var/lib/lidarr/
chmod 0700 /var/lib/lidarr/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively you can use

serviceConfig.StateDirectory=lidarr";
serviceConfig.StateDirectoryMode="0700";

see man systemd.exec

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't mode 770 better, so that users in the "lidarr" group also have access?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@symphorien Oh, didn't know that. I mostly copied the package and service from Sonarr. Pushed with 0770 as mode as suggeste by @bjornfor

@etu
lidarr: init at 0.3.1.471
1ba5e23 
Fork of sonarr (as radarr) but for music instead of series and movies.
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: lidarr

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lidarr

Partial log (click to expand)

/nix/store/pb1gixslgn5ag3i3z6n5aciq2p8fjc5d-lidarr-0.3.1.471

@etu etu closed this Sep 23, 2018
@etu etu deleted the lidarr-package branch September 23, 2018 05:45
@etu etu restored the lidarr-package branch September 23, 2018 05:45
@etu
Copy link
Contributor Author

etu commented Sep 23, 2018

Oops, I deleted the branch. Recreated.

@etu etu reopened this Sep 23, 2018
@edwtjo
Copy link
Member

edwtjo commented Sep 29, 2018

LGTM, rebased and applied in aba9598

@edwtjo edwtjo closed this Sep 29, 2018
@etu etu deleted the lidarr-package branch September 29, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor left review comments

@symphorien symphorien symphorien left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@etu @GrahamcOfBorg @edwtjo @bjornfor @symphorien @worldofpeace