Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tifffile: fix python 2 build #46415

Merged
merged 1 commit into from Sep 9, 2018
Merged

pythonPackages.tifffile: fix python 2 build #46415

merged 1 commit into from Sep 9, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Sep 9, 2018 •
edited

/cc #45960

Motivation for this change

fix python 2 build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mbode mbode requested a review from FRidh as a code owner September 9, 2018 09:56
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

@GrahamcOfBorg build python27Packages.tifffile

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.tifffile

Partial log (click to expand)

test_tifffile.TestSave.test_imsave_roundtrip(<type 'numpy.int16'>, array([[[28369, 12716, 26060, 21372], ... ok
test_tifffile.TestSave.test_imsave_roundtrip(<type 'numpy.float64'>, array([[[2.57466478e-01, 9.58594447e-01, 8.18057397e-01, 7.24228606e-01], ... ok
test_tifffile.test_imread_uint16 ... SKIP: Skipping test: test_imread_uint16: Test skipped due to test condition
test_tifffile.test_imread_uint16_big_endian ... SKIP: Skipping test: test_imread_uint16_big_endian: Test skipped due to test condition

----------------------------------------------------------------------
Ran 17 tests in 0.199s

OK (SKIP=2)
/nix/store/zx98shvfn89gmjjskpw48phjmsmswbg6-python2.7-tifffile-0.15.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.tifffile

Partial log (click to expand)

test_tifffile.TestSave.test_imsave_roundtrip(<type 'numpy.int16'>, array([[[28369, 12716, 26060, 21372], ... ok
test_tifffile.TestSave.test_imsave_roundtrip(<type 'numpy.float64'>, array([[[2.57466478e-01, 9.58594447e-01, 8.18057397e-01, 7.24228606e-01], ... ok
test_tifffile.test_imread_uint16 ... SKIP: Skipping test: test_imread_uint16: Test skipped due to test condition
test_tifffile.test_imread_uint16_big_endian ... SKIP: Skipping test: test_imread_uint16_big_endian: Test skipped due to test condition

----------------------------------------------------------------------
Ran 17 tests in 0.872s

OK (SKIP=2)
/nix/store/wgqhcwbl7scrigkhirbi6n08125araa3-python2.7-tifffile-0.15.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.tifffile

Partial log (click to expand)

test_tifffile.TestSave.test_imsave_roundtrip(<type 'numpy.int16'>, array([[[28369, 12716, 26060, 21372], ... ok
test_tifffile.TestSave.test_imsave_roundtrip(<type 'numpy.float64'>, array([[[2.57466478e-01, 9.58594447e-01, 8.18057397e-01, 7.24228606e-01], ... ok
test_tifffile.test_imread_uint16 ... SKIP: Skipping test: test_imread_uint16: Test skipped due to test condition
test_tifffile.test_imread_uint16_big_endian ... SKIP: Skipping test: test_imread_uint16_big_endian: Test skipped due to test condition

----------------------------------------------------------------------
Ran 17 tests in 0.623s

OK (SKIP=2)
/nix/store/28rfk6kvkl16zzbxqb20gb6icvp8dw4a-python2.7-tifffile-0.15.1

@xeji xeji merged commit c020a59 into NixOS:master Sep 9, 2018
xeji pushed a commit that referenced this pull request Sep 9, 2018
@mbode @xeji
pythonPackages.tifffile: fix python 2 build (#46415)
32a4cbc 
(cherry picked from commit c020a59)
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

backported: 32a4cbc

@mbode mbode deleted the tifffile-pathlib branch September 9, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @xeji @GrahamcOfBorg