pythonPackages.mahotas: fix build, move expression #46368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timokau
reviewed
Sep 8, 2018
See https://hydra.nixos.org/build/80828287 Moves `mahotas` out of `python-packages.nix` into its own file and fixes broken test cases by skipping them using nosetest's `@nottest` annotation. These tests broke from time to time in a sandbox and are therefore considered impure. Addresses NixOS#45960
|
@timokau this fixes a Hydra failure for 18.09. Would you mind backporting this? :) |
|
While this works on master, it still fails on 18.09: https://hydra.nixos.org/jobset/nixos/release-18.09/jobs-tab?filter=mahotas @Ma27 can you have a look please? |
|
ouch, I'm sorry for this! Will have a look at this tonight! |
|
@xeji I just had a look into it. Unfortunately I can't reliably reproduce the issue with |
|
These failures look like they can be hardware-dependent due to different arithmetic precision. |
9 tasks
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Sep 17, 2018
…texture.test_haralick3d` testcase As stated in NixOS#46368, this package seems to have issues with impure tests (reported in luispedro/mahotas#97). Unfortunately the `release-18.09` job on Hydra fails at the attempt to build this package since `test_moments.test_normalize1` and `test_texture.test_haralick3d` breaks. Until the root cause is identified, we skip the disabled tests to ensure that the resulting package is not entirely broken (which can't be confirmed with `doCheck = false`). See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175 /cc @xeji @luispedro
xeji
pushed a commit
that referenced
this pull request
Sep 17, 2018
…texture.test_haralick3d` testcase (#46793) As stated in #46368, this package seems to have issues with impure tests (reported in luispedro/mahotas#97). Unfortunately the `release-18.09` job on Hydra fails at the attempt to build this package since `test_moments.test_normalize1` and `test_texture.test_haralick3d` breaks. Until the root cause is identified, we skip the disabled tests to ensure that the resulting package is not entirely broken (which can't be confirmed with `doCheck = false`). See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175 /cc @xeji @luispedro (cherry picked from commit 5f2eacc)
xeji
pushed a commit
that referenced
this pull request
Sep 17, 2018
…texture.test_haralick3d` testcase (#46793) As stated in #46368, this package seems to have issues with impure tests (reported in luispedro/mahotas#97). Unfortunately the `release-18.09` job on Hydra fails at the attempt to build this package since `test_moments.test_normalize1` and `test_texture.test_haralick3d` breaks. Until the root cause is identified, we skip the disabled tests to ensure that the resulting package is not entirely broken (which can't be confirmed with `doCheck = false`). See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175 /cc @xeji @luispedro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See https://hydra.nixos.org/build/80828287
Moves
mahotasout ofpython-packages.nixinto its own file and fixesbroken test cases by skipping them using nosetest's
@nottestannotation.
These tests broke from time to time in a sandbox and are therefore
considered impure.
Addresses #45960
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)