pdf2htmlEX: mark as broken #46369
pdf2htmlEX: mark as broken #46369
Conversation
See https://hydra.nixos.org/build/81003667 The build is currently broken on Hydra due to the following error: ``` CairoFontEngine.cc:681:17: error: 'void Object::free()' is private within this context ``` This issue is was also reported in AUR (https://aur.archlinux.org/packages/pdf2htmlex/) and in the upstream issue tracker (coolwanglu/pdf2htmlEX#753) with no answer until now. The current README.md states that the project is no longer under active development and it seems as there are currently no active maintainers who could fix this: * coolwanglu/pdf2htmlEX@5d0a223 * coolwanglu/pdf2htmlEX#772
| @@ -43,5 +43,6 @@ stdenv.mkDerivation rec { | |||
| license = licenses.gpl3Plus; | |||
| maintainers = [ maintainers.taktoa ]; | |||
| platforms = with platforms; linux; | |||
| broken = true; # 2018-09-08 | |||
There was a problem hiding this comment.
Would you mind adding the information from the issue description (link to upstream issue and AUR commit, no longer maintained) as a comment?
There was a problem hiding this comment.
honest question: isn't it sufficient to write it into the commit message (which is what I usually do) or do you prefer the information as code comment as well?:)
There was a problem hiding this comment.
I think having the information as a comment is vastly more useful. When somebody in the future wonders "why is this broken? can I maybe fix this?" they can just check the comment, read the explanation and check the linked sources. When the information is hidden in a comment message he might be able to find that with git-blame, but only if the code hasn't been moved around or heavily refactored since then.
I'm not exactly happy that @Mic92 merged this already, but the info in the commit message will do for now.
There was a problem hiding this comment.
Unlikely to happen for broken status, because the next change will hopefully remove the broken attribute again.
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: pdf2htmlEX Partial log (click to expand)
|
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: pdf2htmlEX Partial log (click to expand)
|
Motivation for this change
See https://hydra.nixos.org/build/81003667
The build is currently broken on Hydra due to the following error:
This issue is was also reported in AUR (https://aur.archlinux.org/packages/pdf2htmlex/)
and in the upstream issue tracker (coolwanglu/pdf2htmlEX#753) with
no answer until now.
The current README.md states that the project is no longer under active
development and it seems as there are currently no active maintainers
who could fix this:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)