Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.03] firefox{,-bin} 61.0.2 -> 62.0, firefox-esr: 60.1.0esr -> 60.2.esr #46417

Merged
merged 3 commits into from Sep 10, 2018

Conversation

andir
Copy link
Member

@andir andir commented Sep 9, 2018

Motivation for this change

This backports @taku0's firefox 62 update PR #46157 to 18.03.

The many difference to the original branch is that. I did not end up upgrading to a compatible sqlite version (0.23.0 IIRC) sine that introduced a bunch of failures (e.g. sqlalchemy started failing etc..). Instead the bundled sqlite version is being used. I did not want to introduce yet another mass-rebuild and a bunch of package bumps just because firefox gets bumped. 18.09 is already on it's way and this will hopefully be (one of) the last firefox upgrade we have on 18.03 :-)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They run for me OK.

@vcunat vcunat merged commit 7a1ccf2 into NixOS:release-18.03 Sep 10, 2018
vcunat added a commit that referenced this pull request Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants