Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.persistent: fix build #46364

Merged
merged 1 commit into from Sep 8, 2018
Merged

pythonPackages.persistent: fix build #46364

merged 1 commit into from Sep 8, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 8, 2018 •
edited

Motivation for this change

https://hydra.nixos.org/build/80547563

ZHF #45960 . Documentation-related tests failed, the docs didn't build correctly because of missing dependencies sphinx and manuel. Add them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions

@xeji
pythonPackages.persistent: fix build
1b7d649 
Documentation-related tests failed, the docs didn't build correctly
because of missing dependencies sphinx and manuel. Add them.
@xeji xeji requested a review from FRidh as a code owner September 8, 2018 13:05
@xeji
Copy link
Contributor Author

xeji commented Sep 8, 2018

@GrahamcOfBorg build python2.pkgs.persistent python3.pkgs.persistent

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.persistent, python3.pkgs.persistent

Partial log (click to expand)

test___repr___converts_legacy_container_attr (persistent.tests.test_mapping.PersistentMappingTests) ... ok
test_volatile_attributes_not_persisted (persistent.tests.test_mapping.PersistentMappingTests) ... ok
test___get___from_class (persistent.tests.test_mapping.Test_default) ... ok
test___get___from_instance (persistent.tests.test_mapping.Test_default) ... ok
test_PD_is_alias_to_PM (persistent.tests.test_mapping.Test_legacy_PersistentDict) ... ok

----------------------------------------------------------------------
Ran 524 tests in 0.268s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.persistent, python3.pkgs.persistent

Partial log (click to expand)

test___eq___w_rhs_gone_target_not_in_jar (persistent.tests.test_wref.WeakRefTests) ... ok
test___hash___w_target (persistent.tests.test_wref.WeakRefTests) ... ok
test___hash___wo_target (persistent.tests.test_wref.WeakRefTests) ... ok
test_ctor_target_w_jar (persistent.tests.test_wref.WeakRefTests) ... ok
test_ctor_target_wo_jar (persistent.tests.test_wref.WeakRefTests) ... ok

----------------------------------------------------------------------
Ran 524 tests in 0.225s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.persistent, python3.pkgs.persistent

Partial log (click to expand)

test_insert (persistent.tests.test_list.TestPList) ... ok
test_remove (persistent.tests.test_list.TestPList) ... ok
test_reverse (persistent.tests.test_list.TestPList) ... ok
test_setslice (persistent.tests.test_list.TestPList) ... ok
test_volatile_attributes_not_persisted (persistent.tests.test_list.TestPList) ... ok

----------------------------------------------------------------------
Ran 524 tests in 1.257s

OK

@xeji xeji mentioned this pull request Sep 8, 2018
Closed
@xeji xeji merged commit 113f4d7 into NixOS:master Sep 8, 2018
@xeji xeji deleted the p/persistent branch September 8, 2018 19:35
xeji added a commit that referenced this pull request Sep 8, 2018
@xeji
pythonPackages.persistent: fix build (#46364)
3ecacb1 
Documentation-related tests failed, the docs didn't build correctly
because of missing dependencies sphinx and manuel. Add them.

(cherry picked from commit 113f4d7)
@xeji
Copy link
Contributor Author

xeji commented Sep 8, 2018

backported: 3ecacb1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg