Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wkhtmltopdf: 0.12.4 -> 0.12.5, use Qt5 #46392

Merged
merged 1 commit into from Sep 9, 2018
Merged

wkhtmltopdf: 0.12.4 -> 0.12.5, use Qt5 #46392

merged 1 commit into from Sep 9, 2018

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Sep 8, 2018

Motivation for this change

Upgrade the version of wkhtmltopdf.

Also (ref #33248), use Qt5 instead of Qt4, and don't use the patched version of webkit (also what Arch does).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @jb55 (package maintainer)

@Mic92
Copy link
Member

Mic92 commented Sep 9, 2018

@GrahamcOfBorg build wkhtmltopdf

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: wkhtmltopdf

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wkhtmltopdf

Partial log (click to expand)

shrinking /nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5/lib/libwkhtmltox.so.0.12.5
shrinking /nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5/bin/wkhtmltoimage
shrinking /nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5/bin/wkhtmltopdf
gzipping man pages under /nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5/lib  /nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5/bin
patching script interpreter paths in /nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5
checking for references to /build in /nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5...
postPatchMkspecs
/nix/store/gwsql5aha6k0aqi4pp3y9715lblbvw3n-wkhtmltopdf-0.12.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wkhtmltopdf

Partial log (click to expand)

shrinking /nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5/bin/wkhtmltoimage
shrinking /nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5/bin/wkhtmltopdf
shrinking /nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5/lib/libwkhtmltox.so.0.12.5
gzipping man pages under /nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5/lib  /nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5/bin
patching script interpreter paths in /nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5
checking for references to /build in /nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5...
postPatchMkspecs
/nix/store/mihggs5yi968268qapcmwzsvwxkqnhyn-wkhtmltopdf-0.12.5

@Mic92 Mic92 merged commit ab8f0aa into NixOS:master Sep 9, 2018
@andrew-d andrew-d deleted the adunham/wkhtmltopdf-qt5 branch September 9, 2018 21:04
@andrew-d andrew-d mentioned this pull request Sep 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-d @Mic92 @GrahamcOfBorg