Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono-addins: fix build #46354

Merged
merged 1 commit into from Sep 8, 2018
Merged

Conversation

worldofpeace
Copy link
Contributor

This build fails I assume for the same reason #46060 does.
We'd also prefer to use msbuild as it would fix this but it's not packaged

Motivation for this change

This build failure

Failure adding assembly ../bin/Mono.Addins.dll to the cache: Strong name cannot be verified for delay-signed assembly

ZHF: #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

@GrahamcOfBorg build mono-addins

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: mono-addins

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mono-addins

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m4a5ydiwdihgx0yjzq5riix4ybh2g465-mono-addins-1.2
gzipping man pages under /nix/store/m4a5ydiwdihgx0yjzq5riix4ybh2g465-mono-addins-1.2/share/man/
patching script interpreter paths in /nix/store/m4a5ydiwdihgx0yjzq5riix4ybh2g465-mono-addins-1.2
/nix/store/m4a5ydiwdihgx0yjzq5riix4ybh2g465-mono-addins-1.2/bin/mautil: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/m4a5ydiwdihgx0yjzq5riix4ybh2g465-mono-addins-1.2...
/nix/store/m4a5ydiwdihgx0yjzq5riix4ybh2g465-mono-addins-1.2

@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

This pins the direct mono dependency to mono48, but mono-addins -> gtk-sharp_2_0 -> mono still brings in mono5. (I found out when investigating why this doesn't eval on aarch64).
Can mono48 and mono5 be mixed at runtime? Did you test that these addins actually work now?

@worldofpeace
Copy link
Contributor Author

This pins the direct mono dependency to mono48, but mono-addins -> gtk-sharp_2_0 -> mono still brings in mono5. (I found out when investigating why this doesn't eval on aarch64).

Thanks for doing something that I should have been doing 😄

Can mono48 and mono5 be mixed at runtime? Did you test that these addins actually work now?

Excellent question, I would think that you could not mix them but I'm not familiar with mono
(nudge to the respective maintainers in nixpkgs).

As for testing I can say that pinta builds and runs though I'm not sure what it uses the addins for.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: mono-addins

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

tomboy uses mono46 and depends on mono-addins and gtk-sharp_2_0. So there was a mix of mono versions before this PR...

@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

Anyway, I will merge this as it improves the current situation, and tomboy is the only other package depending on it (banshee is marked as broken).

@xeji xeji merged commit 2031c0e into NixOS:master Sep 8, 2018
xeji pushed a commit that referenced this pull request Sep 8, 2018
(cherry picked from commit 2031c0e)
@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

backported: 26d65fa

@worldofpeace worldofpeace deleted the mono-addins/fix-build branch September 8, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants