Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.CDDB: fix darwin build #46412

Merged
merged 1 commit into from Sep 9, 2018
Merged

pythonPackages.CDDB: fix darwin build #46412

merged 1 commit into from Sep 9, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Sep 9, 2018 •
edited

/cc #45961

Motivation for this change

fix darwin build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mbode mbode requested a review from FRidh as a code owner September 9, 2018 08:15
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

@GrahamcOfBorg build python27Packages.CDDB

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.CDDB

Partial log (click to expand)

these paths will be fetched (0.82 MiB download, 1.00 MiB unpacked):
  /nix/store/na61qmyadmxkkhfyk7cyyib7f8cm8ys1-python2.7-CDDB-1.4
  /nix/store/w2cdqjbjcz7334a547pjxc0jwhq27nc4-python2.7-setuptools-40.2.0
copying path '/nix/store/w2cdqjbjcz7334a547pjxc0jwhq27nc4-python2.7-setuptools-40.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/na61qmyadmxkkhfyk7cyyib7f8cm8ys1-python2.7-CDDB-1.4' from 'https://cache.nixos.org'...
/nix/store/na61qmyadmxkkhfyk7cyyib7f8cm8ys1-python2.7-CDDB-1.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.CDDB

Partial log (click to expand)

reading manifest file 'CDDB.egg-info/SOURCES.txt'
writing manifest file 'CDDB.egg-info/SOURCES.txt'
running build_ext
copying build/lib.macosx-10.10-x86_64-2.7/cdrom.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/f1m2c8px346j74ifazf2y8jrw977mn8m-python2.7-CDDB-1.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.CDDB

Partial log (click to expand)

these paths will be fetched (0.01 MiB download, 0.03 MiB unpacked):
  /nix/store/5jcyc1lc7kqc2nraqv2p4937pi035sg4-python2.7-CDDB-1.4
copying path '/nix/store/5jcyc1lc7kqc2nraqv2p4937pi035sg4-python2.7-CDDB-1.4' from 'https://cache.nixos.org'...
/nix/store/5jcyc1lc7kqc2nraqv2p4937pi035sg4-python2.7-CDDB-1.4

@xeji xeji merged commit 5b1b4ad into NixOS:master Sep 9, 2018
xeji pushed a commit that referenced this pull request Sep 9, 2018
@mbode @xeji
pythonPackages.CDDB: fix darwin build (#46412)
50bc216 
(cherry picked from commit 5b1b4ad)
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

backported: 50bc216

@mbode mbode deleted the cddb_iokit branch September 9, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @xeji @GrahamcOfBorg