Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jbake: fix sandbox build #46363

Merged
merged 1 commit into from Sep 8, 2018
Merged

jbake: fix sandbox build #46363

merged 1 commit into from Sep 8, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 8, 2018 •
edited

Motivation for this change

See https://hydra.nixos.org/build/80999410

Without a sandbox the checkPhase breaks with the following error:

/nix/store/i6vl5lwlz5jbkg4r6p340dwmj6fha3xq-stdenv-linux/setup: bin/jbake: /usr/bin/env: bad interpreter: No such file or directory
jbake did not return correct version

Running patchShebangs before fixes the issue.

Addresses #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
jbake: fix sandbox build
04b6f42 
See https://hydra.nixos.org/build/80999410

Without a sandbox the `checkPhase` breaks with the following error:

```
/nix/store/i6vl5lwlz5jbkg4r6p340dwmj6fha3xq-stdenv-linux/setup: bin/jbake: /usr/bin/env: bad interpreter: No such file or directory
jbake did not return correct version
```

Running `patchShebangs` before fixes the issue.

Addresses NixOS#45960
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jbake

Partial log (click to expand)

'lib/snappy-java-1.1.0.1.jar' -> '/nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1/lib/snappy-java-1.1.0.1.jar'
'lib/thymeleaf-3.0.9.RELEASE.jar' -> '/nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1/lib/thymeleaf-3.0.9.RELEASE.jar'
'lib/unbescape-1.1.5.RELEASE.jar' -> '/nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1/lib/unbescape-1.1.5.RELEASE.jar'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1/lib  /nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1/bin
patching script interpreter paths in /nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1
checking for references to /build in /nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1...
/nix/store/qm0g6grllvxl4z00f3cg8rc5ksi0hvfb-jbake-2.6.1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: jbake

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit 6960a96 into NixOS:master Sep 8, 2018
xeji pushed a commit that referenced this pull request Sep 8, 2018
@Ma27 @xeji
jbake: fix sandbox build (#46363)
a05c49a 
See https://hydra.nixos.org/build/80999410

Without a sandbox the `checkPhase` breaks with the following error:

```
/nix/store/i6vl5lwlz5jbkg4r6p340dwmj6fha3xq-stdenv-linux/setup: bin/jbake: /usr/bin/env: bad interpreter: No such file or directory
jbake did not return correct version
```

Running `patchShebangs` before fixes the issue.

Addresses #45960

(cherry picked from commit 6960a96)
@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

backported: a05c49a

@Ma27 Ma27 deleted the fix-jbake branch September 8, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @xeji