Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive: Adds patch for missing synctex header. (Fixes zathura build) #46376

Merged
merged 1 commit into from Sep 9, 2018

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Sep 8, 2018

Motivation for this change

This seems like a known issue as other distributions (ArchLinux here)
have patches fixing the issue.

This hopefully fixes more than one dependant builds for ZHF 18.09. #45960

This is marked WIP because I'll be using ofborg's output to figure out other affected packages, and see if there are issues... Though I expect the list to be a bit big since texlive is deeply entrenched.

With a superficial look, it seems to only fix zathura builds.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ⬜ macOS
    • ⬜ other Linux distributions
  • ⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ⬜ Tested execution of all binary files (usually in ./result/bin/)
  • ⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Fits CONTRIBUTING.md.

zathura notes

My current tests are that zathura builds, and starts. It seems that zathura could have other issues than that, making it subtly broken, while building. (Alternatively, I could be using it wrong.)

In the console:

error: Can not copy to temporary file: Operation not supported

In zathura's gui

Could not read file from GIO and copy it to a temporary file.

I expect fully that those are irrelevant to the change from this PR.


@samueldr samueldr changed the title [WIP] texlive: Adds patch for missing synctex header. texlive: Adds patch for missing synctex header. (Fixes zathura build) Sep 8, 2018
@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

11k rebuilds. staging, maybe?

@samueldr
Copy link
Member Author

samueldr commented Sep 8, 2018

@xeji probably (I'm still not clear when staging and not-staging has to happen, so I'll follow your lead.)

@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

@samueldr there seem to be no hard rules but >10k rebuilds definitely qualifies for staging as it would be a pain for people working on master...
BTW, your branch still needs a rebase and force-push to to get rid of the too-many commits...

@samueldr
Copy link
Member Author

samueldr commented Sep 8, 2018

Oh, github's UI didn't make it obvious fixing fixed.

@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

yep, changing base of an existing PR is always fun 😄

This seems like a known issue as other distributions (ArchLinux here)
have patches fixing the issue.

This hopefully fixes more than one dependant builds for ZHF 18.09.
@samueldr
Copy link
Member Author

samueldr commented Sep 8, 2018

Fixed, mentioning since you commented just before.

@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

@GrahamcOfBorg build texlive.bin.core

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: texlive.bin.core

Partial log (click to expand)

shrinking /nix/store/1npng9vq3grnf6isc4l7qda56y8zg5d8-texlive-bin-2018/lib/libsynctex.so.1.21.0
shrinking /nix/store/1npng9vq3grnf6isc4l7qda56y8zg5d8-texlive-bin-2018/lib/libkpathsea.so.6.3.0
strip is /nix/store/gsywj1aslzxxlgnarpl5h73f0fj0balx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1npng9vq3grnf6isc4l7qda56y8zg5d8-texlive-bin-2018/lib  /nix/store/1npng9vq3grnf6isc4l7qda56y8zg5d8-texlive-bin-2018/bin
patching script interpreter paths in /nix/store/1npng9vq3grnf6isc4l7qda56y8zg5d8-texlive-bin-2018
checking for references to /build in /nix/store/1npng9vq3grnf6isc4l7qda56y8zg5d8-texlive-bin-2018...
shrinking RPATHs of ELF executables and libraries in /nix/store/fd52y4405sc62a2j2q70d2rv9pd2ajm4-texlive-bin-2018-doc
strip is /nix/store/gsywj1aslzxxlgnarpl5h73f0fj0balx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/fd52y4405sc62a2j2q70d2rv9pd2ajm4-texlive-bin-2018-doc
checking for references to /build in /nix/store/fd52y4405sc62a2j2q70d2rv9pd2ajm4-texlive-bin-2018-doc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: texlive.bin.core

Partial log (click to expand)

shrinking /nix/store/h1a45gnn07rn87wkcz5zldxn8qb7jw4v-texlive-bin-2018/lib/libkpathsea.so.6.3.0
strip is /nix/store/61y59vmb9wy49kkm5pjzqgsihc05366g-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h1a45gnn07rn87wkcz5zldxn8qb7jw4v-texlive-bin-2018/lib  /nix/store/h1a45gnn07rn87wkcz5zldxn8qb7jw4v-texlive-bin-2018/bin
patching script interpreter paths in /nix/store/h1a45gnn07rn87wkcz5zldxn8qb7jw4v-texlive-bin-2018
checking for references to /build in /nix/store/h1a45gnn07rn87wkcz5zldxn8qb7jw4v-texlive-bin-2018...
shrinking RPATHs of ELF executables and libraries in /nix/store/3wn51fph1477iw55ljr147q43f36hs3w-texlive-bin-2018-doc
strip is /nix/store/61y59vmb9wy49kkm5pjzqgsihc05366g-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3wn51fph1477iw55ljr147q43f36hs3w-texlive-bin-2018-doc
checking for references to /build in /nix/store/3wn51fph1477iw55ljr147q43f36hs3w-texlive-bin-2018-doc...
/nix/store/h1a45gnn07rn87wkcz5zldxn8qb7jw4v-texlive-bin-2018

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: texlive.bin.core

Partial log (click to expand)

cannot build derivation '/nix/store/b05rb88drkc3nycjlwzrpbnhjnsabh9z-xmlto-0.0.28.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/fbd0pr17fw2vh08fs7xxhhf6cbxafm1k-giflib-5.1.4.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/4vkp2w5d31c10xr1ymdnjdaak2v966yp-openjpeg-2.3.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/z96nfd4h2g0wrpasg0bwnd2wqa8k4ndr-poppler-data-0.4.9.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/3xrjp3j702f5b83npxj2msr97lc2k42x-zziplib-0.13.69.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/q7y2ba9xrxb078iby0c2pjmzd6vp3acv-libwebp-1.0.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/yr1jf6wsfzlnllfqigb09rc2imj54mhb-poppler-min-0.67.0.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/c14rmlaz1mz05yw7jvxnzxqm4kkh4gjq-gd-2.2.5.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/ncsfvhiin1b1vfsmw1a4y0m6gs8klisc-texlive-bin-2018.drv': 13 dependencies couldn't be built
error: build of '/nix/store/ncsfvhiin1b1vfsmw1a4y0m6gs8klisc-texlive-bin-2018.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

@GrahamcOfBorg build zathura

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: zathura

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@xeji
Copy link
Contributor

xeji commented Sep 8, 2018

darwin timeout building llvm, nothing we can do about it on ofborg.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: zathura

Partial log (click to expand)

  CCLD     action-namespace
building of '/nix/store/1phfr6sy8kkwfi3ag4n84rcm6m51xacj-gtk+3-3.22.30.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/hzfcjr65zc8cx6nal9ggrm2d8lspg0ny-appstream-glib-0.7.10.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7lj5z94qdgfcdrzsv696psir41j49k1i-girara-0.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1ls0rhj23mjh0gsd6gy291nmb6fkr0ff-zathura-core-0.4.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/0bgd2swbc722pggb4xwdkjcpg9g2d17a-zathura-djvu-0.2.8.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/rgr72fl7ysnn54kvyhg6f8bp8v5iln27-zathura-pdf-mupdf-0.3.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/23424sic3g3n477ir7qwrwfkdlfb2xcv-zathura-ps-0.2.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gjxyz78v82w93dbvp4y9p5iqdiijh580-zathura-with-plugins-0.4.0.drv': 4 dependencies couldn't be built
error: build of '/nix/store/gjxyz78v82w93dbvp4y9p5iqdiijh580-zathura-with-plugins-0.4.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: zathura

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/w54ldwn28a6a54qfm1922a577sjk5a9i-appstream-glib-0.7.10-installedTests
strip is /nix/store/61y59vmb9wy49kkm5pjzqgsihc05366g-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w54ldwn28a6a54qfm1922a577sjk5a9i-appstream-glib-0.7.10-installedTests
checking for references to /build in /nix/store/w54ldwn28a6a54qfm1922a577sjk5a9i-appstream-glib-0.7.10-installedTests...
cannot build derivation '/nix/store/l9nc2ga6fhkp8sffimbxym8izbps5nyk-zathura-core-0.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mfch267srs3q57in8nqd06fdak0fljdp-zathura-djvu-0.2.8.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/jvvjqyjhzp6rc401dpm4skhmmf9vg65l-zathura-pdf-mupdf-0.3.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hrw35888ggdn97gaa2kml7cphrzmkcwc-zathura-ps-0.2.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/niz2cdkw51aadzkz2lkp8w518hw2hxsh-zathura-with-plugins-0.4.0.drv': 4 dependencies couldn't be built
error: build of '/nix/store/niz2cdkw51aadzkz2lkp8w518hw2hxsh-zathura-with-plugins-0.4.0.drv' failed

@xeji xeji merged commit 1ac912b into NixOS:staging Sep 9, 2018
xeji pushed a commit that referenced this pull request Sep 9, 2018
This seems like a known issue as other distributions (ArchLinux here)
have patches fixing the issue.

This hopefully fixes more than one dependant builds for ZHF 18.09.

(cherry picked from commit 1ac912b)
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

picked to staging-18.09 in 97916ac . The staging-18.09 hydra jobset is configured to eval only every 2 days, so this may take a while.

globin pushed a commit to mayflower/nixpkgs that referenced this pull request Sep 13, 2018
This seems like a known issue as other distributions (ArchLinux here)
have patches fixing the issue.

This hopefully fixes more than one dependant builds for ZHF 18.09.

(cherry picked from commit 1ac912b)
(cherry picked from commit 97916ac)
@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

@samueldr unfortunately this doesn't seem to fix zathura (at least not on 18.09, it's not in master yet): https://hydra.nixos.org/build/81598308 failed at 8b04b63 , after this patch was just merged into 18.09. I can reproduce this locally. What surprises me is that hydra calls it a cached failure, so this patch doesn't even change zathura's derivation hash. Strange.

cc @timokau

@globin
Copy link
Member

globin commented Sep 17, 2018

I've just worked on fixing this:
mayflower@6101fbebca3

Still testing but (now) looks correct.

Edit: second try

@globin
Copy link
Member

globin commented Sep 17, 2018

Currently running hydra jobset with above patch applied: https://hydra.mayflower.de/eval/4572#tabs-unfinished

Will push to staging and staging-18.09 if it's successful.

globin added a commit to mayflower/nixpkgs that referenced this pull request Sep 17, 2018
The automake file was patched but `automake` not run.
Also since the texk/web2c folder is not in autoconfig's
SUBDIRS the autoreconfHook has to be run in there.

Completely fixes NixOS#46376
@samueldr samueldr deleted the zhf/synctex-failure branch September 18, 2018 02:38
@samueldr
Copy link
Member Author

Now I'm wondering how I got it building... since I remember starting zathura to check it worked. I'm guessing I could have mistakenly used a stale result from an earlier build and was distracted :/. Sorry.

@globin
Copy link
Member

globin commented Sep 18, 2018

Still doesn't fix zathura, but that looks unrelated, it definitely fixes the missing synctex header.

globin added a commit that referenced this pull request Sep 18, 2018
The automake file was patched but `automake` not run.
Also since the texk/web2c folder is not in autoconfig's
SUBDIRS the autoreconfHook has to be run in there.

Completely fixes #46376
globin added a commit that referenced this pull request Sep 18, 2018
The automake file was patched but `automake` not run.
Also since the texk/web2c folder is not in autoconfig's
SUBDIRS the autoreconfHook has to be run in there.

Completely fixes #46376

(cherry picked from commit ce6e72a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants