Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgit: use full path of groff in man2html #46418

Merged
merged 1 commit into from Sep 9, 2018
Merged

cgit: use full path of groff in man2html #46418

merged 1 commit into from Sep 9, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 9, 2018

Motivation for this change

groff may not be installed system-wide or may be outside cgit's path
(e.g. when running cgit using uwsgi). As a result, the man2html filter
fails. Replace groff by its full path in man2html.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danieldk
cgit: use full path of groff in man2html
bbcf5eb 
groff may not be installed system-wide or may be outside cgit's path
(e.g. when running cgit using uwsgi). As a result, the man2html filter
fails. Replace groff by its full path in man2html.
@Mic92 Mic92 merged commit c60ba3c into NixOS:master Sep 9, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 9, 2018

18.09:

[detached HEAD 7d404b9] cgit: use full path of groff in man2html
Author: Daniël de Kok me@danieldk.eu
Date: Sun Sep 9 14:37:30 2018 +0200
1 file changed, 4 insertions(+), 1 deletion(-)

@danieldk danieldk deleted the cgit-fix-man2html branch September 9, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @Mic92 @GrahamcOfBorg