Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbuilder: 1.0.1 -> dune: 1.1.1 #46411

Merged
merged 1 commit into from Sep 15, 2018
Merged

jbuilder: 1.0.1 -> dune: 1.1.1 #46411

merged 1 commit into from Sep 15, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 9, 2018

Motivation for this change

Update and use the new name.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@@ -1398,8 +1400,6 @@ with pkgs;

interlock = callPackage ../servers/interlock {};

jbuilder = callPackage ../development/tools/ocaml/jbuilder { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add it to pkgs/top-level/aliases.nix

@Mic92
Copy link
Member

Mic92 commented Sep 9, 2018

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented Sep 9, 2018

pyre also needs an update now.

@Mic92
Copy link
Member

Mic92 commented Sep 9, 2018

@vbgl vbgl merged commit fc19401 into NixOS:master Sep 15, 2018
@vbgl vbgl deleted the dune-1.1 branch September 15, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants