kodiPlugins: add YATP, drop exodus #46403

oxij · 2018-09-08T22:56:32Z

Motivation for this change

Continuation of #46196. A mass rebuild.

Things done

Builds and works without issues

Note: after adding yatp into kodiWithPlugins you have to enable YATP manually in Kodi UI.

Merge at will.

GrahamcOfBorg · 2018-09-08T23:45:09Z

Success on x86_64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0v6x9xqpmyip96mhb7dvnpivqbdnzcqg-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/0v6x9xqpmyip96mhb7dvnpivqbdnzcqg-kodi-plugin-yatp-3.3.2
checking for references to /build in /nix/store/0v6x9xqpmyip96mhb7dvnpivqbdnzcqg-kodi-plugin-yatp-3.3.2...
/nix/store/bvnbh70qlxdjhp2dafj69zn8c36zzh1h-kodi-plugin-simpleplugin-2.3.2
/nix/store/0v6x9xqpmyip96mhb7dvnpivqbdnzcqg-kodi-plugin-yatp-3.3.2

GrahamcOfBorg · 2018-09-09T00:37:58Z

Success on aarch64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/di7pwx7k9d56ir6hss8w6r9p6yk6x9sr-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/di7pwx7k9d56ir6hss8w6r9p6yk6x9sr-kodi-plugin-yatp-3.3.2
checking for references to /build in /nix/store/di7pwx7k9d56ir6hss8w6r9p6yk6x9sr-kodi-plugin-yatp-3.3.2...
/nix/store/pqmg5zj65iww13qmzjmi0scvy92d5sg0-kodi-plugin-simpleplugin-2.3.2
/nix/store/di7pwx7k9d56ir6hss8w6r9p6yk6x9sr-kodi-plugin-yatp-3.3.2

xeji · 2018-09-09T09:50:28Z

The mass rebuild seems to by caused by dropping the split outputs of pythonPackages.requests.
Is that really necessary to build the kodi plugins?

oxij · 2018-09-09T11:05:05Z

The mass rebuild seems to by caused by dropping the split outputs of `pythonPackages.requests`. Is that really necessary to build the `kodi` plugins?

Hm. Looking at this with a fresh eye I now think I misunderstood what empty "dev" output of `pythonPackages.requests` on `master` did. It contains `nix-support/propagated-build-inputs` file, which now makes sense to me. Removed that patch and fixed `yatp` expression instead. This should now go to `master`, as it no longer a mass rebuild. But don't merge yet, I want to test this revision too.

GrahamcOfBorg · 2018-09-09T11:13:14Z

Success on x86_64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3pvz9s1ksqg5jf7avfgms7y0ipd1q9h3-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/3pvz9s1ksqg5jf7avfgms7y0ipd1q9h3-kodi-plugin-yatp-3.3.2
checking for references to /build in /nix/store/3pvz9s1ksqg5jf7avfgms7y0ipd1q9h3-kodi-plugin-yatp-3.3.2...
/nix/store/bvnbh70qlxdjhp2dafj69zn8c36zzh1h-kodi-plugin-simpleplugin-2.3.2
/nix/store/3pvz9s1ksqg5jf7avfgms7y0ipd1q9h3-kodi-plugin-yatp-3.3.2

FRidh · 2018-09-09T11:15:28Z

Yes, the requests thing is ugly, but its a consequence of Python packages unfortunately using propagatedBuildInputs.

GrahamcOfBorg · 2018-09-09T14:55:21Z

Success on aarch64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n0haxi1w4gh4jqgh3jix1jhpvcf3kgn1-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/n0haxi1w4gh4jqgh3jix1jhpvcf3kgn1-kodi-plugin-yatp-3.3.2
checking for references to /build in /nix/store/n0haxi1w4gh4jqgh3jix1jhpvcf3kgn1-kodi-plugin-yatp-3.3.2...
/nix/store/pqmg5zj65iww13qmzjmi0scvy92d5sg0-kodi-plugin-simpleplugin-2.3.2
/nix/store/n0haxi1w4gh4jqgh3jix1jhpvcf3kgn1-kodi-plugin-yatp-3.3.2

GrahamcOfBorg · 2018-09-10T18:10:31Z

Success on aarch64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/583wjlmz11b0g16d6v24b7xwbm2rgdzb-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/583wjlmz11b0g16d6v24b7xwbm2rgdzb-kodi-plugin-yatp-3.3.2
checking for references to /build in /nix/store/583wjlmz11b0g16d6v24b7xwbm2rgdzb-kodi-plugin-yatp-3.3.2...
/nix/store/jvxdq68dlcy878gd0gppkd84nfalf65w-kodi-plugin-simpleplugin-2.3.2
/nix/store/583wjlmz11b0g16d6v24b7xwbm2rgdzb-kodi-plugin-yatp-3.3.2

GrahamcOfBorg · 2018-09-10T18:10:32Z

Success on x86_64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r24mr9fmjp187zf3dzcr21yn38ywximp-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/r24mr9fmjp187zf3dzcr21yn38ywximp-kodi-plugin-yatp-3.3.2
checking for references to /build in /nix/store/r24mr9fmjp187zf3dzcr21yn38ywximp-kodi-plugin-yatp-3.3.2...
/nix/store/h51bg87wk936qlm7d0n53k165aif6zbg-kodi-plugin-simpleplugin-2.3.2
/nix/store/r24mr9fmjp187zf3dzcr21yn38ywximp-kodi-plugin-yatp-3.3.2

xeji · 2018-09-11T22:19:16Z

@oxij is this ready to merge now?

oxij · 2018-09-11T22:38:24Z

Nope, unfortunately YATP doesn't start with multiple-output `requests`. :( I'll investigate later this week.

The `dev` output is empty anyway. The problem is that it interacts badly with other parts of python and stdenv infrastructure. In particular, before this patch it installs code into `out` output (with only generated `nix-support` in `dev`), but `makePythonPath` then uses `propagatedBuildInputs` to generate `PYTHONPATH` while stdenv selects `dev` outputs for `propagatedBuiltInputs`. This results in `makePythonPath` linking to the empty `dev` output in `PYTHONPATH`. This reverts a piece of commit 28299f6.

No loner exists, I couldn't find an official replacement repo, should be removed according to NixOS#46196 (comment)

GrahamcOfBorg · 2018-11-07T08:33:50Z

Success on aarch64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5q70fxc1mpx9z4g4vw5snlxv02h7biym-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/5q70fxc1mpx9z4g4vw5snlxv02h7biym-kodi-plugin-yatp-3.3.2
checking for references to /build in /nix/store/5q70fxc1mpx9z4g4vw5snlxv02h7biym-kodi-plugin-yatp-3.3.2...
/nix/store/mckn472sakvmhkm6s7qw1dsi6yqpf44r-kodi-plugin-simpleplugin-2.3.2
/nix/store/5q70fxc1mpx9z4g4vw5snlxv02h7biym-kodi-plugin-yatp-3.3.2

oxij · 2018-11-07T08:35:37Z

After digging through the internals I came to the conclusion that the original approach was correct. See the commit messages. I think this need some more input from @FRidh.

GrahamcOfBorg · 2018-11-07T08:40:44Z

Success on x86_64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ry609fp15dzx2d8ybj4q0cnzyysysjgj-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/ry609fp15dzx2d8ybj4q0cnzyysysjgj-kodi-plugin-yatp-3.3.2
checking for references to /build in /nix/store/ry609fp15dzx2d8ybj4q0cnzyysysjgj-kodi-plugin-yatp-3.3.2...
/nix/store/8bdqk239zqb1mhl8wnwzb4j8fs40ppf6-kodi-plugin-simpleplugin-2.3.2
/nix/store/ry609fp15dzx2d8ybj4q0cnzyysysjgj-kodi-plugin-yatp-3.3.2

oxij · 2018-11-18T09:22:36Z

@FRidh ping. In particular, I want some input on 5c60dce

oxij · 2018-11-18T09:24:58Z

Btw, after digging this I now feel like going through all multi-output python packages and removing multiple outputs from those that have dev output empty. What is the point of the empty dev output anyway?

FRidh · 2018-11-18T09:30:25Z

Btw, after digging this I now feel like going through all multi-output python packages and removing multiple outputs from those that have dev output empty. What is the point of the empty dev output anyway?

Yes, we should remove multiple outputs in case of Python packages because it doesn't work. As soon as an output is defined, the propagated-build-inputs is no longer written it seems.

The original idea was to get certain build-time dependencies out of a closure if I understood correctly, but that seems to have been resolved elsewhere already.

oxij · 2018-11-18T10:16:56Z

So this should be good to merge to staging then, is it not?

FRidh · 2018-11-18T10:20:06Z

Note I suggest that Kodi packages are going to be put in a file of their own. That gives the possibility to use @r-ryantm

GrahamcOfBorg · 2018-11-18T10:34:32Z

Success on x86_64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g2f8xy2crmmmxwhm76qfbywi334a9fwc-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/g2f8xy2crmmmxwhm76qfbywi334a9fwc-kodi-plugin-yatp-3.3.2
checking for references to /build/ in /nix/store/g2f8xy2crmmmxwhm76qfbywi334a9fwc-kodi-plugin-yatp-3.3.2...
/nix/store/nfb88k93q7hpslz14mg7s9mrb4z3vba9-kodi-plugin-simpleplugin-2.3.2
/nix/store/g2f8xy2crmmmxwhm76qfbywi334a9fwc-kodi-plugin-yatp-3.3.2

GrahamcOfBorg · 2018-11-18T11:14:17Z

Success on aarch64-linux (full log)

Attempted: kodiPlugins.simpleplugin, kodiPlugins.yatp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/877i1b63q74dkvyg78zn24zms88ri9g9-kodi-plugin-yatp-3.3.2
patching script interpreter paths in /nix/store/877i1b63q74dkvyg78zn24zms88ri9g9-kodi-plugin-yatp-3.3.2
checking for references to /build/ in /nix/store/877i1b63q74dkvyg78zn24zms88ri9g9-kodi-plugin-yatp-3.3.2...
/nix/store/ff9mb8lsijldq46qnahy876mrdc9br8k-kodi-plugin-simpleplugin-2.3.2
/nix/store/877i1b63q74dkvyg78zn24zms88ri9g9-kodi-plugin-yatp-3.3.2

oxij · 2018-11-18T12:19:31Z

I see, I'll keep that in mind. Anyway. Thanks!

oxij requested a review from FRidh as a code owner September 8, 2018 22:56

oxij mentioned this pull request Sep 8, 2018

kodi: implement kodiWithPlugins, add more plugins #46196

Merged

2 tasks

GrahamcOfBorg added 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ labels Sep 8, 2018

oxij force-pushed the pkgs/kodi-yatp branch from c060eec to 9e064f9 Compare September 9, 2018 10:59

GrahamcOfBorg removed the 6.topic: python label Sep 9, 2018

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ labels Sep 9, 2018

oxij changed the base branch from staging to master September 10, 2018 17:56

oxij added 4 commits November 7, 2018 08:19

kodiPlugins.simpleplugin: init at 2.3.2

eb12f1d

kodiPlugins.yatp: init at 3.3.2

e2944a5

kodiPlugins.exodus: remove

47bf25c

No loner exists, I couldn't find an official replacement repo, should be removed according to NixOS#46196 (comment)

oxij force-pushed the pkgs/kodi-yatp branch from 9e064f9 to 47bf25c Compare November 7, 2018 08:20

GrahamcOfBorg added 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ and removed 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Nov 7, 2018

FRidh changed the base branch from master to staging November 18, 2018 10:19

FRidh merged commit f78835e into NixOS:staging Nov 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kodiPlugins: add YATP, drop exodus #46403

kodiPlugins: add YATP, drop exodus #46403

oxij commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 9, 2018

xeji commented Sep 9, 2018

oxij commented Sep 9, 2018 via email

GrahamcOfBorg commented Sep 9, 2018

FRidh commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 10, 2018

GrahamcOfBorg commented Sep 10, 2018

xeji commented Sep 11, 2018

oxij commented Sep 11, 2018 via email

GrahamcOfBorg commented Nov 7, 2018

oxij commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

oxij commented Nov 18, 2018

oxij commented Nov 18, 2018

FRidh commented Nov 18, 2018

oxij commented Nov 18, 2018 via email

FRidh commented Nov 18, 2018

GrahamcOfBorg commented Nov 18, 2018

GrahamcOfBorg commented Nov 18, 2018

oxij commented Nov 18, 2018 via email

kodiPlugins: add YATP, drop exodus #46403

kodiPlugins: add YATP, drop exodus #46403

Conversation

oxij commented Sep 8, 2018

Motivation for this change

Things done

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 9, 2018

xeji commented Sep 9, 2018

oxij commented Sep 9, 2018 via email

GrahamcOfBorg commented Sep 9, 2018

FRidh commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 10, 2018

GrahamcOfBorg commented Sep 10, 2018

xeji commented Sep 11, 2018

oxij commented Sep 11, 2018 via email

GrahamcOfBorg commented Nov 7, 2018

oxij commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

oxij commented Nov 18, 2018

oxij commented Nov 18, 2018

FRidh commented Nov 18, 2018

oxij commented Nov 18, 2018 via email

FRidh commented Nov 18, 2018

GrahamcOfBorg commented Nov 18, 2018

GrahamcOfBorg commented Nov 18, 2018

oxij commented Nov 18, 2018 via email