Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4eaa7ef1591d
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5fa7404db974
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Sep 8, 2018

  1. yabause: 0.9.14 -> 0.9.15 (#46353)

    + fixes for Qt 5.11 build.
    
    (cherry picked from commit 2c751dc)
    samueldr authored and xeji committed Sep 8, 2018

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    5fa7404 View commit details
67 changes: 67 additions & 0 deletions pkgs/misc/emulators/yabause/0001-Fixes-for-Qt-5.11-upgrade.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
From 3140afd6fb7dad7a25296526a71b005fb9eae048 Mon Sep 17 00:00:00 2001
From: Samuel Dionne-Riel <samuel@dionne-riel.com>
Date: Sat, 8 Sep 2018 00:44:08 -0400
Subject: [PATCH] Fixes for Qt 5.11 upgrade

---
src/qt/ui/UICheatRaw.cpp | 2 --
src/qt/ui/UICheatRaw.h | 2 +-
src/qt/ui/UICheats.cpp | 2 ++
src/qt/ui/UIHexInput.h | 2 ++
4 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/qt/ui/UICheatRaw.cpp b/src/qt/ui/UICheatRaw.cpp
index 4ad82d77..3f78486b 100755
--- a/src/qt/ui/UICheatRaw.cpp
+++ b/src/qt/ui/UICheatRaw.cpp
@@ -20,8 +20,6 @@
#include "UIHexInput.h"
#include "../QtYabause.h"

-#include <QButtonGroup>
-
UICheatRaw::UICheatRaw( QWidget* p )
: QDialog( p )
{
diff --git a/src/qt/ui/UICheatRaw.h b/src/qt/ui/UICheatRaw.h
index d97b429d..20318c67 100755
--- a/src/qt/ui/UICheatRaw.h
+++ b/src/qt/ui/UICheatRaw.h
@@ -21,7 +21,7 @@

#include "ui_UICheatRaw.h"

-class QButtonGroup;
+#include <QButtonGroup>

class UICheatRaw : public QDialog, public Ui::UICheatRaw
{
diff --git a/src/qt/ui/UICheats.cpp b/src/qt/ui/UICheats.cpp
index c6027972..44d341c3 100755
--- a/src/qt/ui/UICheats.cpp
+++ b/src/qt/ui/UICheats.cpp
@@ -21,6 +21,8 @@
#include "UICheatRaw.h"
#include "../CommonDialogs.h"

+#include <QButtonGroup>
+
UICheats::UICheats( QWidget* p )
: QDialog( p )
{
diff --git a/src/qt/ui/UIHexInput.h b/src/qt/ui/UIHexInput.h
index f333b016..4bd8aed4 100644
--- a/src/qt/ui/UIHexInput.h
+++ b/src/qt/ui/UIHexInput.h
@@ -22,6 +22,8 @@
#include "ui_UIHexInput.h"
#include "../QtYabause.h"

+#include <QValidator>
+
class HexValidator : public QValidator
{
Q_OBJECT
--
2.16.4

17 changes: 10 additions & 7 deletions pkgs/misc/emulators/yabause/default.nix
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
{ stdenv, fetchurl, cmake, pkgconfig, qtbase, libGLU_combined
{ stdenv, fetchurl, cmake, pkgconfig, qtbase, qt5, libGLU_combined
, freeglut ? null, openal ? null, SDL2 ? null }:

stdenv.mkDerivation rec {
name = "yabause-${version}";
# 0.9.15 only works with OpenGL 3.2 or later:
# https://github.com/Yabause/yabause/issues/349
version = "0.9.14";
version = "0.9.15";

src = fetchurl {
url = "https://download.tuxfamily.org/yabause/releases/${version}/${name}.tar.gz";
sha256 = "0nkpvnr599g0i2mf19sjvw5m0rrvixdgz2snav4qwvzgfc435rkm";
sha256 = "1cn2rjjb7d9pkr4g5bqz55vd4pzyb7hg94cfmixjkzzkw0zw8d23";
};

nativeBuildInputs = [ cmake pkgconfig ];
buildInputs = [ qtbase libGLU_combined freeglut openal SDL2 ];
buildInputs = [ qtbase qt5.qtmultimedia libGLU_combined freeglut openal SDL2 ];

patches = [ ./emu-compatibility.com.patch ./linkage-rwx-linux-elf.patch ];
patches = [
./linkage-rwx-linux-elf.patch
# Fixes derived from
# https://github.com/Yabause/yabause/commit/06a816c032c6f7fd79ced6e594dd4b33571a0e73
./0001-Fixes-for-Qt-5.11-upgrade.patch
];

cmakeFlags = [
"-DYAB_NETWORK=ON"
10 changes: 0 additions & 10 deletions pkgs/misc/emulators/yabause/emu-compatibility.com.patch

This file was deleted.