Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.libnacl: fix build on darwin #46731

Merged
merged 1 commit into from Sep 16, 2018
Merged

pythonPackages.libnacl: fix build on darwin #46731

merged 1 commit into from Sep 16, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 16, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl vbgl added 6.topic: python 6.topic: darwin Running or building packages on Darwin labels Sep 16, 2018
@vbgl vbgl requested a review from FRidh as a code owner September 16, 2018 06:43
@Mic92
Copy link
Member

Mic92 commented Sep 16, 2018

@GrahamcOfBorg build python36Packages.libnacl python27Packages.libnacl

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.libnacl, python27Packages.libnacl

Partial log (click to expand)

these paths will be fetched (0.04 MiB download, 0.23 MiB unpacked):
  /nix/store/0vckpim47m092d8193w2vqhlj610s18k-python3.6-libnacl-1.6.1
  /nix/store/30rbkv0bx8f2a58yz88ysg39csc6bbg2-python2.7-libnacl-1.6.1
copying path '/nix/store/30rbkv0bx8f2a58yz88ysg39csc6bbg2-python2.7-libnacl-1.6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/0vckpim47m092d8193w2vqhlj610s18k-python3.6-libnacl-1.6.1' from 'https://cache.nixos.org'...
/nix/store/0vckpim47m092d8193w2vqhlj610s18k-python3.6-libnacl-1.6.1
/nix/store/30rbkv0bx8f2a58yz88ysg39csc6bbg2-python2.7-libnacl-1.6.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.libnacl, python27Packages.libnacl

Partial log (click to expand)

tests/unit/test_sign.py .                                                [ 76%]
tests/unit/test_version.py ...                                           [100%]

========================== 43 passed in 0.67 seconds ===========================
tests/unit/test_verify.py .......                                        [ 93%]
tests/unit/test_version.py ...                                           [100%]

========================== 43 passed in 0.70 seconds ===========================
/nix/store/75k5b375nzq72pnlx1ixjx67ydmw06dv-python3.6-libnacl-1.6.1
/nix/store/7ijz4p6ddgl1pazkly7dz9bld3dwp8wa-python2.7-libnacl-1.6.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.libnacl, python27Packages.libnacl

Partial log (click to expand)

  /nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6
  /nix/store/w2cdqjbjcz7334a547pjxc0jwhq27nc4-python2.7-setuptools-40.2.0
copying path '/nix/store/ffjjy533rfy8l9qif1c7xc9qd9mcmvf4-libsodium-1.0.16-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/w2cdqjbjcz7334a547pjxc0jwhq27nc4-python2.7-setuptools-40.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/9iymw7xp3g33drkkq78ln4i8iamrxwgr-python2.7-libnacl-1.6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/minh73n2na8kpbavi9xp84c9d9gh39ia-python3.6-setuptools-40.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/q9s1j2kg6mbs8c5wiwpl5w7s0c737fqr-python3.6-libnacl-1.6.1' from 'https://cache.nixos.org'...
/nix/store/q9s1j2kg6mbs8c5wiwpl5w7s0c737fqr-python3.6-libnacl-1.6.1
/nix/store/9iymw7xp3g33drkkq78ln4i8iamrxwgr-python2.7-libnacl-1.6.1

@Mic92 Mic92 merged commit 33ccf04 into NixOS:master Sep 16, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 16, 2018

backport: 8a26f19

@vbgl vbgl deleted the python-libnacl-darwin branch September 16, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Mic92 @GrahamcOfBorg