Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dendropy: fix build #46745

Merged
merged 1 commit into from Sep 16, 2018
Merged

pythonPackages.dendropy: fix build #46745

merged 1 commit into from Sep 16, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 16, 2018

Motivation for this change

Fixing another random failure for ZHF #45960.

Build failed after update to 4.4.0 because the tests are incorrectly packaged in the pypi version.
Switch to upstream github repo, fix tests, disable failing test cases.

Things done
  • built in a sandbox on NixOS.

@xeji
pythonPackages.dendropy: fix build
a66c00d 
Build failed after update to 4.4.0 because the tests are incorrectly
packages in the pypi version.
Switch to upstream github repo, fix tests, disable failing test cases
@xeji xeji requested a review from FRidh as a code owner September 16, 2018 15:44
@xeji
Copy link
Contributor Author

xeji commented Sep 16, 2018

@GrahamcOfBorg build python27Packages.dendropy python36Packages.dendropy

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.dendropy, python36Packages.dendropy

Partial log (click to expand)

tests/test_tree_summarization_and_consensus.py .......                   [100%]

=============================== warnings summary ===============================
tests/test_datamodel_annotations.py::TestObject
  cannot collect test class 'TestObject' because it has a __init__ constructor

-- Docs: https://docs.pytest.org/en/latest/warnings.html
=========== 838 passed, 17 deselected, 1 warnings in 374.12 seconds ============
/nix/store/jfksnzcjmndz0qbldp8wiwv6f6apvwzq-python2.7-DendroPy-4.4.0
/nix/store/3hivk9wnc79c1fsp16zay73j9cc5cx7d-python3.6-DendroPy-4.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.dendropy, python36Packages.dendropy

Partial log (click to expand)

tests/test_tree_summarization_and_consensus.py .......                   [100%]

=============================== warnings summary ===============================
tests/test_datamodel_annotations.py::TestObject
  cannot collect test class 'TestObject' because it has a __init__ constructor

-- Docs: https://docs.pytest.org/en/latest/warnings.html
=========== 838 passed, 17 deselected, 1 warnings in 455.10 seconds ============
/nix/store/5w8kvbrswcf1xc8al6sx49vfp9cb3n2n-python2.7-DendroPy-4.4.0
/nix/store/vygm36cf7zbsrdqqfqr6yc12d97k1hbg-python3.6-DendroPy-4.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.dendropy, python36Packages.dendropy

Partial log (click to expand)

tests/test_tree_summarization_and_consensus.py .......                   [100%]

=============================== warnings summary ===============================
tests/test_datamodel_annotations.py::TestObject
  cannot collect test class 'TestObject' because it has a __init__ constructor

-- Docs: https://docs.pytest.org/en/latest/warnings.html
=========== 838 passed, 17 deselected, 1 warnings in 2678.65 seconds ===========
/nix/store/fqybppw03w0jahpkxb76mlisk8haisrr-python2.7-DendroPy-4.4.0
/nix/store/8n4sjx3c3ja70pqj3vnlr2y7z265d7vd-python3.6-DendroPy-4.4.0

@Mic92 Mic92 merged commit dd0c2cf into NixOS:master Sep 16, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 16, 2018

backport: 3e10c37

@xeji xeji deleted the p/dendropy branch September 16, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @Mic92