Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lightdm: use systemd.tmpfiles #46734

Merged
merged 1 commit into from Sep 17, 2018
Merged

nixos/lightdm: use systemd.tmpfiles #46734

merged 1 commit into from Sep 17, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

A while ago I noticed with elementary that the data dir /var/lib/lightdm-data/<username> didn't have the correct permissions for their wallpaper switcher to set the greeters wallpaper (that is create a file there called wallpaper).

So this is a general improvement that came out of that.

For Clarity

I deleted --log-dir=/var/log --run-dir=/run in execCmd because these will be set to /var/log/lightdm and /var/run/lightdm by default.

Also the correct home location is /var/lib/lightdm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/lightdm: use systemd.tmpfiles
1bf2d72 
This also makes logs appear at /var/log/lightdm
@worldofpeace worldofpeace changed the title lightdm: use systemd.tmpfiles nixos/lightdm: use systemd.tmpfiles Sep 16, 2018
@Mic92 Mic92 added this to the 18.09 milestone Sep 16, 2018
@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

We can test lightdm via the gnome3 test:
@GrahamcOfBorg test gnome3

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.gnome3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.gnome3

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 59.02s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/igiarq24l7xws3ckkpkgzp5ag9y0b7f8-vm-test-run-gnome3

@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

Also ran nixos/tests/lightdm locally. LGTM.

@xeji xeji merged commit 67e9571 into NixOS:master Sep 17, 2018
xeji pushed a commit that referenced this pull request Sep 17, 2018
@worldofpeace @xeji
nixos/lightdm: use systemd.tmpfiles (#46734)
03f1f35 
This also makes logs appear at /var/log/lightdm

(cherry picked from commit 67e9571)
@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

backported to 18.09: 03f1f35

@worldofpeace
Copy link
Contributor Author

Thanks ❇️ @xeji

@worldofpeace worldofpeace deleted the lightdm/tmpfiles branch September 17, 2018 12:23
@xeji xeji mentioned this pull request Sep 19, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @xeji @GrahamcOfBorg @Mic92