Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deedle: 1.2.0 -> 1.2.5 #46702

Merged
merged 1 commit into from Sep 15, 2018
Merged

Deedle: 1.2.0 -> 1.2.5 #46702

merged 1 commit into from Sep 15, 2018

Conversation

bobvanderlinden
Copy link
Member

Deedle was outdated and the build was failing.

This probably needs backporting to 18.09 (#45960)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

@GrahamcOfBorg build dotnetPackages.Deedle

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dotnetPackages.Deedle

Partial log (click to expand)

'package/services/metadata/core-properties' -> '/nix/store/qpbjfj3gvf82yq6hsjcxfhmkrpmbz4zs-Deedle-1.2.5/lib/dotnet/Deedle/package/services/metadata/core-properties'
'package/services/metadata/core-properties/07a4c2792ac349408c5fcc8906c6bac5.psmdcp' -> '/nix/store/qpbjfj3gvf82yq6hsjcxfhmkrpmbz4zs-Deedle-1.2.5/lib/dotnet/Deedle/package/services/metadata/core-properties/07a4c2792ac349408c5fcc8906c6bac5.psmdcp'
/nix/store/qpbjfj3gvf82yq6hsjcxfhmkrpmbz4zs-Deedle-1.2.5 /build
/build
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qpbjfj3gvf82yq6hsjcxfhmkrpmbz4zs-Deedle-1.2.5
patching script interpreter paths in /nix/store/qpbjfj3gvf82yq6hsjcxfhmkrpmbz4zs-Deedle-1.2.5
checking for references to /build in /nix/store/qpbjfj3gvf82yq6hsjcxfhmkrpmbz4zs-Deedle-1.2.5...
/nix/store/qpbjfj3gvf82yq6hsjcxfhmkrpmbz4zs-Deedle-1.2.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dotnetPackages.Deedle

Partial log (click to expand)

'package/services' -> '/nix/store/zdzbn2gzf21djk72zcz0c17kp2lbbnxq-Deedle-1.2.5/lib/dotnet/Deedle/package/services'
'package/services/metadata' -> '/nix/store/zdzbn2gzf21djk72zcz0c17kp2lbbnxq-Deedle-1.2.5/lib/dotnet/Deedle/package/services/metadata'
'package/services/metadata/core-properties' -> '/nix/store/zdzbn2gzf21djk72zcz0c17kp2lbbnxq-Deedle-1.2.5/lib/dotnet/Deedle/package/services/metadata/core-properties'
'package/services/metadata/core-properties/07a4c2792ac349408c5fcc8906c6bac5.psmdcp' -> '/nix/store/zdzbn2gzf21djk72zcz0c17kp2lbbnxq-Deedle-1.2.5/lib/dotnet/Deedle/package/services/metadata/core-properties/07a4c2792ac349408c5fcc8906c6bac5.psmdcp'
/nix/store/zdzbn2gzf21djk72zcz0c17kp2lbbnxq-Deedle-1.2.5 /private/tmp/nix-build-Deedle-1.2.5.drv-0
/private/tmp/nix-build-Deedle-1.2.5.drv-0
glibPreFixupPhase
post-installation fixup
patching script interpreter paths in /nix/store/zdzbn2gzf21djk72zcz0c17kp2lbbnxq-Deedle-1.2.5
/nix/store/zdzbn2gzf21djk72zcz0c17kp2lbbnxq-Deedle-1.2.5

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dotnetPackages.Deedle

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

This seems to download a prebuilt binary (same with Paket earlier). It would be preferable to build from source.

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

But it's better than a failing build, so let's merge anyway 😄

@xeji xeji merged commit 76001b8 into NixOS:master Sep 15, 2018
xeji pushed a commit that referenced this pull request Sep 15, 2018
@bobvanderlinden @xeji
Deedle: 1.2.0 -> 1.2.5 (#46702)
f829dbf 
(cherry picked from commit 76001b8)
@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

backported: f829dbf

@bobvanderlinden
Copy link
Member Author

@xeji, indeed. For Deedle specifically, it didn't have the 1.2.5 tag on Github :/ 1.2.4 was released 3 years ago :( I guess it is maintained poorly.

@bobvanderlinden bobvanderlinden deleted the pr-deedle-1.2.5 branch September 15, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @xeji @GrahamcOfBorg