New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
particl-qt: init at 0.18.1.4 #46760
particl-qt: init at 0.18.1.4 #46760
Conversation
@GrahamcOfBorg build particl-qt |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: particl-qt Partial log (click to expand)
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Please rebase and resolve merge conflict. You can also try |
9f9016b
to
de9fe01
Compare
I rebase and did same with boost. Also check UI tests - working. I guess |
You're right, |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: particl-qt Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Im confused, this built well on my laptop. Also I already saw this error when I try to build .17-Alfa, but back then I decide its due to unstable version. |
Let's start the build again and see if anything changes. |
@GrahamcOfBorg build particl-qt |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: particl-qt Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Since the build for x86_64-linux succeeded now I would assume the parallel build is non-deterministic (some internal dependencies not properly specified). The obvious solution is to disable parallel building. |
de980a1
to
2e3e578
Compare
Thanks @xeji ! Disabled parallel building option for particl-qt and rebased to latest master. It appears that C headers that should be generated by protobuf before compilation of usbdevice/ folder (needed for trezor hardware wallet support) occasionally was not generated during parallel build. Something for Particl team to look at. |
I agree. It would be great if you could report that upstream. @GrahamcOfBorg build particl-qt |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: particl-qt Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
]; | ||
|
||
# Parallel building become non-deterministic for particl-qt (see nixpkgs pr #46760) | ||
enableParallelBuiling = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of the typo here, parallel building was NOT disabled...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, me bad. Fixed it. Reported problem and it's fixed in current unstable version: particl/particl-core@b620bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
2e3e578
to
82b508c
Compare
@GrahamcOfBorg build particl-qt |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: particl-qt Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Same error. Now I'm not sure if parallel build has to do something with it. |
I agree. Let's mark this as WIP and wait. |
Failure on aarch64-linux (full log) Attempted: particl-qt Partial log (click to expand)
|
Are there any updates on this pull request, please? |
82b508c
to
9d27714
Compare
@mmahut pull request updated with actual version of source. |
9d27714
to
276e845
Compare
Closing, because mainline Particle-Core updated to v0.19 this PR adds outdated version. |
Motivation for this change
Particl QT wallet that can be used to activate cold staking with Ladger hardware wallet.
Works Linux only so far.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)