Make it more obvious that nixos options in the search results are clickable #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While talking to someone that just started looking into NixOS we figured out that he wasn't aware that those search results were clickable at all. While we already changed the cursor while hovering the entries you would not really be hinted into clicking on them. This is especially relevant for people using keyboard navigation (vim-style or similar) since those entries wouldn't show up as clickable. With this commit I am just wrapping the text in an anchor tag. That is enough to make them appear like other links on the website. They also appear as clickable when using keyboard navigation.
|
👍 10/10 💯 the right way to handle this:
(I was waiting for movement on #160 to propose the fix into what was thought to be eventually replacing the options page for UX things.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While talking to someone that just started looking into NixOS we figured
out that he wasn't aware that those search results were clickable at
all. While we already changed the cursor while hovering the entries you
would not really be hinted into clicking on them.
This is especially relevant for people using keyboard navigation
(vim-style or similar) since those entries wouldn't show up as
clickable.
With this commit I am just wrapping the text in an anchor tag. That is
enough to make them appear like other links on the website. They also
appear as clickable when using keyboard navigation.
Before
After