Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyodbc: fix build #46703

Merged
merged 1 commit into from Sep 15, 2018
Merged

pythonPackages.pyodbc: fix build #46703

merged 1 commit into from Sep 15, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 15, 2018

Motivation for this change

ZHF #45960.
Build failed with libiodbc after pyodbc 4.0.23->4.0.24 update: https://hydra.nixos.org/build/80724929.

To fix, build with unixODBC instead of libiodbc, see discussion in mkleehammer/pyodbc#444

Things done
  • Built in a sandbox on NixOS

@xeji
pythonPackages.pyodbc: fix build
b0b2f2f 
Build with unixODBC instead of libiodbc, see discussion in
mkleehammer/pyodbc#444
@xeji xeji requested a review from FRidh as a code owner September 15, 2018 15:47
@xeji
Copy link
Contributor Author

xeji commented Sep 15, 2018

@GrahamcOfBorg build python27Packages.pyodbc python36Packages.pyodbc

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.pyodbc, python36Packages.pyodbc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pyodbc, python36Packages.pyodbc

Partial log (click to expand)

/build/pyodbc-4.0.24
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dnhchvc5kwqn7x3vwb6cz16rlks379xx-python3.6-pyodbc-4.0.24
shrinking /nix/store/dnhchvc5kwqn7x3vwb6cz16rlks379xx-python3.6-pyodbc-4.0.24/lib/python3.6/site-packages/pyodbc.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dnhchvc5kwqn7x3vwb6cz16rlks379xx-python3.6-pyodbc-4.0.24/lib
patching script interpreter paths in /nix/store/dnhchvc5kwqn7x3vwb6cz16rlks379xx-python3.6-pyodbc-4.0.24
checking for references to /build in /nix/store/dnhchvc5kwqn7x3vwb6cz16rlks379xx-python3.6-pyodbc-4.0.24...
/nix/store/37bm3i2c1cphbcdknlglkwipd2y3kdvm-python2.7-pyodbc-4.0.24
/nix/store/dnhchvc5kwqn7x3vwb6cz16rlks379xx-python3.6-pyodbc-4.0.24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pyodbc, python36Packages.pyodbc

Partial log (click to expand)

/build/pyodbc-4.0.24
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pgfsk51m1wwwk2a2q6ibmnj9awvnw882-python3.6-pyodbc-4.0.24
shrinking /nix/store/pgfsk51m1wwwk2a2q6ibmnj9awvnw882-python3.6-pyodbc-4.0.24/lib/python3.6/site-packages/pyodbc.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pgfsk51m1wwwk2a2q6ibmnj9awvnw882-python3.6-pyodbc-4.0.24/lib
patching script interpreter paths in /nix/store/pgfsk51m1wwwk2a2q6ibmnj9awvnw882-python3.6-pyodbc-4.0.24
checking for references to /build in /nix/store/pgfsk51m1wwwk2a2q6ibmnj9awvnw882-python3.6-pyodbc-4.0.24...
/nix/store/h0cp9ld68v85ld2gc87kklfl9x7c9fg5-python2.7-pyodbc-4.0.24
/nix/store/pgfsk51m1wwwk2a2q6ibmnj9awvnw882-python3.6-pyodbc-4.0.24

@xeji xeji merged commit 13c500a into NixOS:master Sep 15, 2018
@xeji xeji deleted the p/pyodbc branch September 15, 2018 21:13
xeji added a commit that referenced this pull request Sep 15, 2018
@xeji
pythonPackages.pyodbc: fix build (#46703)
a0ba8bb 
Build with unixODBC instead of libiodbc, see discussion in
mkleehammer/pyodbc#444

(cherry picked from commit 13c500a)
@xeji
Copy link
Contributor Author

xeji commented Sep 15, 2018

backported: a0ba8bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg