emby: 3.4.1.0 -> 3.5.2.0 #46724
Merged
emby: 3.4.1.0 -> 3.5.2.0 #46724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you planning to switch it over to the source build you found? |
That PKGBUILD is using the xbuild tool which has been deprecated in mono50 in favor of msbuild which currently isn't in nixpkgs. (see #29817) So my hunch is even if I were to try xbuild it might not work. |
timokau
requested changes
Sep 16, 2018
pkgs/servers/emby/default.nix
Outdated
|
|
||
| makeWrapper "${mono54}/bin/mono" $out/bin/MediaBrowser.Server.Mono \ | ||
| --add-flags "$out/bin/MediaBrowser.Server.Mono.exe -ffmpeg ${ffmpeg}/bin/ffmpeg -ffprobe ${ffmpeg}/bin/ffprobe" | ||
| ''; | ||
|
|
||
| meta = { | ||
| description = "MediaBrowser - Bring together your videos, music, photos, and live television"; | ||
| homepage = https://emby.media/; | ||
| license = stdenv.lib.licenses.gpl2; | ||
| homepage = https://emby.media/; |
There was a problem hiding this comment.
I've had other contributors actually request me to do this. (I now also prefer it)
Since there still isn't really a formal style guide, I don't think this should be a problem.
There was a problem hiding this comment.
Which other contributor? Horizontal alignment is bad because it
- obscures history (
git blame) - makes diffs harder to read (what was actually changed)
- creates merge conflicts
- has to be maintained in the future
Instead if you do want horizontal alignment, you should get a plugin for your editor/IDE that shows lines aligned but does not actually change the source.
I agree with your point that there is no formal style guide, but since I'm opposed to this and I think its not just preference but actually worse in practice, I won't merge this. Someone else may of course.
worldofpeace
force-pushed
the
emby/3.5.2.0
branch
from
f378e91
to
ba62f9d
Compare
worldofpeace
commented
Sep 17, 2018
| @@ -1,23 +1,30 @@ | |||
| { stdenv, fetchurl, pkgs, unzip, sqlite, makeWrapper, mono54, ffmpeg, ... }: | |||
There was a problem hiding this comment.
I don't know why these were needed so I removed them.
(removed pkgs and ...)
worldofpeace
force-pushed
the
emby/3.5.2.0
branch
from
ba62f9d
to
191ecf7
Compare
|
The point I made here stands. Not sure why github marks that as outdated. |
worldofpeace
force-pushed
the
emby/3.5.2.0
branch
from
191ecf7
to
bd02b33
Compare
timokau
approved these changes
Sep 17, 2018
|
Thank you for your patience :) |
|
❇️ |
|
As noticed in the OP, this happens on upgrade: I was able to fix this by adding u+w permissions on *.dll in |
|
In other words, this is what the directory looked like on my machine: Apparently everything in there needed to be +w. |
|
Maybe we can do something here that if this directory exists we ensure everything in it has the correct permissions. Though I wonder why it isn't so in the first place. |
|
This sort of global state should be avoided when possible because you won't be able to install two versions of emby at the same time with it and I'm not sure if its cleaned up after uninstall. |
|
@timokau Which global state? |
|
In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
An update and #44884 had conflicts.
@numinit noticed this
This is going on here Emby.Server.Implementations.ApplicationHost.CopyPlugins
Any ideas?
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)