Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] php: 5.6.37 -> 5.6.38, 7.0.31 -> 7.0.32 #46717

Merged
merged 2 commits into from Sep 15, 2018
Merged

[18.03] php: 5.6.37 -> 5.6.38, 7.0.31 -> 7.0.32 #46717

merged 2 commits into from Sep 15, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 15, 2018

Motivation for this change

These versions doesn't exist in unstable or 18.09 due to them both being EOL in december this year, but php tend to release bugfixes.

We would need someone to trigger the darwin build to see if the same bug as in #46694 exists in these versions. If so we shouldn't merge this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @xeji

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php56, php70

Partial log (click to expand)

/nix/store/3nlnzjf4nxcim9yfwf6n9xk830vhd8bj-php-7.0.32/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/3nlnzjf4nxcim9yfwf6n9xk830vhd8bj-php-7.0.32/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/3nlnzjf4nxcim9yfwf6n9xk830vhd8bj-php-7.0.32...
moving /nix/store/3nlnzjf4nxcim9yfwf6n9xk830vhd8bj-php-7.0.32/sbin/* to /nix/store/3nlnzjf4nxcim9yfwf6n9xk830vhd8bj-php-7.0.32/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/i2dipvqm6fh5giwzwdqy7qhb17y0yiyi-php-7.0.32-dev
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/i2dipvqm6fh5giwzwdqy7qhb17y0yiyi-php-7.0.32-dev
checking for references to /build in /nix/store/i2dipvqm6fh5giwzwdqy7qhb17y0yiyi-php-7.0.32-dev...
/nix/store/ddczfzmpk52yhc2vlbx6ljzz1a3bcjmj-php-5.6.38
/nix/store/3nlnzjf4nxcim9yfwf6n9xk830vhd8bj-php-7.0.32

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php56, php70

Partial log (click to expand)

/nix/store/mfyjg5zy1p2v4ppdjy92bdva1kqhdyqg-php-7.0.32/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/mfyjg5zy1p2v4ppdjy92bdva1kqhdyqg-php-7.0.32/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/mfyjg5zy1p2v4ppdjy92bdva1kqhdyqg-php-7.0.32...
moving /nix/store/mfyjg5zy1p2v4ppdjy92bdva1kqhdyqg-php-7.0.32/sbin/* to /nix/store/mfyjg5zy1p2v4ppdjy92bdva1kqhdyqg-php-7.0.32/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/k7zv7z3y9nibahv6sls40n0iiligdmvv-php-7.0.32-dev
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/k7zv7z3y9nibahv6sls40n0iiligdmvv-php-7.0.32-dev
checking for references to /build in /nix/store/k7zv7z3y9nibahv6sls40n0iiligdmvv-php-7.0.32-dev...
/nix/store/ndaqr3avlsrmryc2zm0il9mjzxyjf27v-php-5.6.38
/nix/store/mfyjg5zy1p2v4ppdjy92bdva1kqhdyqg-php-7.0.32

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

@GrahamcOfBorg build php56 php70

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php56, php70

Partial log (click to expand)

/nix/store/ddczfzmpk52yhc2vlbx6ljzz1a3bcjmj-php-5.6.38
/nix/store/3nlnzjf4nxcim9yfwf6n9xk830vhd8bj-php-7.0.32

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php56, php70

Partial log (click to expand)

/nix/store/ndaqr3avlsrmryc2zm0il9mjzxyjf27v-php-5.6.38
/nix/store/mfyjg5zy1p2v4ppdjy92bdva1kqhdyqg-php-7.0.32

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: php56, php70

Partial log (click to expand)

/nix/store/0l5c9flavkfdy0jx3kslnhy075kxzim5-php-7.0.32/bin/pecl: interpreter directive changed from "/bin/sh" to "/nix/store/3xp2dmql3fkv0mkfssszxdaxkhzcwzjk-bash-4.4-p12/bin/sh"
/nix/store/0l5c9flavkfdy0jx3kslnhy075kxzim5-php-7.0.32/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/3xp2dmql3fkv0mkfssszxdaxkhzcwzjk-bash-4.4-p12/bin/sh"
/nix/store/0l5c9flavkfdy0jx3kslnhy075kxzim5-php-7.0.32/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/3xp2dmql3fkv0mkfssszxdaxkhzcwzjk-bash-4.4-p12/bin/sh"
/nix/store/0l5c9flavkfdy0jx3kslnhy075kxzim5-php-7.0.32/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/3xp2dmql3fkv0mkfssszxdaxkhzcwzjk-bash-4.4-p12/bin/sh"
/nix/store/0l5c9flavkfdy0jx3kslnhy075kxzim5-php-7.0.32/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/3xp2dmql3fkv0mkfssszxdaxkhzcwzjk-bash-4.4-p12/bin/sh"
moving /nix/store/0l5c9flavkfdy0jx3kslnhy075kxzim5-php-7.0.32/sbin/* to /nix/store/0l5c9flavkfdy0jx3kslnhy075kxzim5-php-7.0.32/bin
strip is /nix/store/yjliwlfl3jlivmysq7372cxw4p42h92v-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/wv57dg5aj70q1dfww0zghkzh2rj949lx-php-7.0.32-dev
/nix/store/mnskh9rwg50dakxjh8vb1aqfi7nyynb2-php-5.6.38
/nix/store/0l5c9flavkfdy0jx3kslnhy075kxzim5-php-7.0.32

@xeji xeji merged commit 01f5e79 into NixOS:release-18.03 Sep 15, 2018
@etu etu deleted the upgrade-1803-php branch September 15, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @GrahamcOfBorg @xeji