Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: skip flaky os/exec TestExtraFiles #46706

Merged
merged 1 commit into from Sep 16, 2018
Merged

go: skip flaky os/exec TestExtraFiles #46706

merged 1 commit into from Sep 16, 2018

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Sep 15, 2018 •
edited

Motivation for this change

Currently the builds regarding go 1.11 on i686-linux are failing. This hits a number of NixOS tests.

The test only fails on i686 and not just on NixOS. It also happens on
Debian. For more information:

golang/go#25628

This probably needs to be backported to 18.09 (#45960)

Closes #46705

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bobvanderlinden
go: skip flaky os/exec TestExtraFiles
0bf6b44 
This seems to only happen on i686 on go 1.11. It also happens on
Debian. For more information:

golang/go#25628
@Mic92
Copy link
Member

Mic92 commented Sep 15, 2018

@GrahamcOfBorg build go_1_11

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: go_1_11

Partial log (click to expand)


ALL TESTS PASSED
---
Installed Go for darwin/amd64 in /nix/store/787cijf7bhkw3wwg22kh1g3ylkg0vinj-go-1.11/share/go
Installed commands in /nix/store/787cijf7bhkw3wwg22kh1g3ylkg0vinj-go-1.11/share/go/bin
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/787cijf7bhkw3wwg22kh1g3ylkg0vinj-go-1.11/bin
patching script interpreter paths in /nix/store/787cijf7bhkw3wwg22kh1g3ylkg0vinj-go-1.11
/nix/store/787cijf7bhkw3wwg22kh1g3ylkg0vinj-go-1.11

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: go_1_11

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/9i6q942h55c4hici0n56da2kd30dggfj-go-1.11

@bobvanderlinden
Copy link
Member Author

bobvanderlinden commented Sep 15, 2018 •
edited

Does it also run on i686-linux? You might want to run the test nixos.tests.prometheus.i686-linux as that one includes go.i686-linux. Currently that build always fails, but should succeed with this PR.

https://hydra.nixos.org/job/nixos/release-18.09/nixos.tests.prometheus.i686-linux

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: go_1_11

Partial log (click to expand)

cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/dpn7f7321la6djc2ccv0i97qn2k1nngj-go-1.11

@Mic92
Copy link
Member

Mic92 commented Sep 16, 2018

@GrahamcOfBorg build pkgsi686Linux.go_1_11

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsi686Linux.go_1_11

Partial log (click to expand)

Cannot nix-instantiate `pkgsi686Linux.go_1_11' because:
error: assertion failed at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/stage.nix:150:21

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: pkgsi686Linux.go_1_11

Partial log (click to expand)

copying path '/nix/store/01h7z9mwx1vzqkj8vywab7j3xx2zfpmj-python2.7-urllib3-1.23' from 'https://cache.nixos.org'...
copying path '/nix/store/yx83j4fjnky2am82dfxq2c00l1xczw6b-bazaar-2.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/dx68h4fsy7izfgbwxxb3pmf5pmkjy5n3-python2.7-dulwich-0.19.6' from 'https://cache.nixos.org'...
copying path '/nix/store/jx05xvfdzd0mkrc6lvwbc0qbxpmhgyma-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/fdp0k6v6vg40ask33mdvpws660vcjmcz-go-1.4-bootstrap-20161024' from 'https://cache.nixos.org'...
copying path '/nix/store/cd0msq9l4xxcl28jfk2kzwfrjkbak8lg-python2.7-hg-git-0.8.11' from 'https://cache.nixos.org'...
copying path '/nix/store/p966ww1qiv0zyhnh92dlv95s9jx0593v-mercurial-4.7.1' from 'https://cache.nixos.org'...
copying path '/nix/store/5bd9r11dj22g75ajn4dqaz0sfb7k19g6-stdenv-linux' from 'https://cache.nixos.org'...
copying path '/nix/store/wq0jd5l20hli879x6nn3mp2gm8av7d79-go-bootstrap' from 'https://cache.nixos.org'...
error: a 'i686-linux' is required to build '/nix/store/wbd71x6jam6pgrrl5004x8qq0jgs2qvm-go-1.11.drv', but I am a 'aarch64-linux'

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pkgsi686Linux.go_1_11

Partial log (click to expand)

cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/f9k4haf4ld34zkhxw378l4978310w5ws-go-1.11

@bobvanderlinden
Copy link
Member Author

👍

@Mic92 Mic92 merged commit c6773e8 into NixOS:master Sep 16, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 16, 2018

backport: 9179259

@bobvanderlinden bobvanderlinden deleted the pr-go-skip-flaky-test branch September 16, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bobvanderlinden @Mic92 @GrahamcOfBorg @orivej