Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyo3-pack: init at 0.3.8 #46754

Merged
merged 1 commit into from Oct 30, 2018
Merged

pyo3-pack: init at 0.3.8 #46754

merged 1 commit into from Oct 30, 2018

Conversation

danieldk
Copy link
Contributor

Motivation for this change

pyo3-pack is a utility for building Python modules in Rust. It works with binding crates such as pyo3 and cpython.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Oct 22, 2018
Closed
@Mic92
Copy link
Member

Mic92 commented Oct 22, 2018

I asked upstream to include a Cargo.lock file

@Mic92
Copy link
Member

Mic92 commented Oct 22, 2018

Now it has one.

@danieldk
Copy link
Contributor Author

Excellent, thanks! I'll update this PR.

@danieldk danieldk changed the title pyo3-pack: init at 0.3.1 pyo3-pack: init at 0.3.7 Oct 22, 2018
@danieldk
Copy link
Contributor Author

Updated to 0.3.7 and squashed into one commit.

@konstin
Copy link

konstin commented Oct 24, 2018

FYI uploading is broken in 0.3.7 due to seanmonstar/reqwest#374. I've published 0.3.8 that should work around that.

@danieldk
Copy link
Contributor Author

Thanks for the heads-up, I'll update this PR to 0.3.8.

@danieldk danieldk changed the title pyo3-pack: init at 0.3.7 pyo3-pack: init at 0.3.3 Oct 25, 2018
@danieldk danieldk changed the title pyo3-pack: init at 0.3.3 pyo3-pack: init at 0.3.8 Oct 25, 2018
@danieldk
Copy link
Contributor Author

Updated to 0.3.8.

@Mic92
Copy link
Member

Mic92 commented Oct 25, 2018

@GrahamcOfBorg build pyo3-pack

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pyo3-pack

Partial log (click to expand)

    Finished release [optimized] target(s) in 2m 10s
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rhb6r9cy4pm923mmc5cg9y5zjkv411a9-pyo3-pack-0.3.8
shrinking /nix/store/rhb6r9cy4pm923mmc5cg9y5zjkv411a9-pyo3-pack-0.3.8/bin/pyo3-pack
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rhb6r9cy4pm923mmc5cg9y5zjkv411a9-pyo3-pack-0.3.8/bin
patching script interpreter paths in /nix/store/rhb6r9cy4pm923mmc5cg9y5zjkv411a9-pyo3-pack-0.3.8
checking for references to /build in /nix/store/rhb6r9cy4pm923mmc5cg9y5zjkv411a9-pyo3-pack-0.3.8...
/nix/store/rhb6r9cy4pm923mmc5cg9y5zjkv411a9-pyo3-pack-0.3.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pyo3-pack

Partial log (click to expand)

    Finished release [optimized] target(s) in 11m 38s
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xqrn5kwflwng0d85ah8nnsra8hk58mi8-pyo3-pack-0.3.8
shrinking /nix/store/xqrn5kwflwng0d85ah8nnsra8hk58mi8-pyo3-pack-0.3.8/bin/pyo3-pack
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xqrn5kwflwng0d85ah8nnsra8hk58mi8-pyo3-pack-0.3.8/bin
patching script interpreter paths in /nix/store/xqrn5kwflwng0d85ah8nnsra8hk58mi8-pyo3-pack-0.3.8
checking for references to /build in /nix/store/xqrn5kwflwng0d85ah8nnsra8hk58mi8-pyo3-pack-0.3.8...
/nix/store/xqrn5kwflwng0d85ah8nnsra8hk58mi8-pyo3-pack-0.3.8

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pyo3-pack

Partial log (click to expand)

   Compiling hyper-tls v0.3.1
   Compiling reqwest v0.9.2
   Compiling pyo3-pack v0.3.68 (file:///private/tmp/nix-build-pyo3-pack-0.3.8.drv-0/source)
    Finished release [optimized] target(s) in 6m 55s
installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/p38v9wi3yqb7l69knr29mha6khljcppa-pyo3-pack-0.3.8/bin
patching script interpreter paths in /nix/store/p38v9wi3yqb7l69knr29mha6khljcppa-pyo3-pack-0.3.8
/nix/store/p38v9wi3yqb7l69knr29mha6khljcppa-pyo3-pack-0.3.8

@xeji xeji merged commit 3a23367 into NixOS:master Oct 30, 2018
@konstin konstin mentioned this pull request Feb 18, 2019
Closed
@danieldk danieldk deleted the pyo3-pack branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danieldk @Mic92 @konstin @GrahamcOfBorg @xeji