Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: vim-plug, fixes and updates #46751

Merged
merged 6 commits into from Sep 20, 2018

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Sep 16, 2018

Motivation for this change

I was unable to make https://github.com/fatih/vim-go work using either the "native" plugin manager, or vam, hence I added a simple vim-plug implementation, which fixed the issue.

  • Added vim-plug implementation of vim addon manager, accessible via configure.plug
  • Fixed Shougo username being spelled with lower-case. See https://github.com/Shougo
  • Updated some plugins along the way

Example usage can be seen here

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@@ -194,6 +195,18 @@ let
execute pathogen#infect('${pluginsEnv}/{}')
'');

/* vim-plug is an extremely popular vim plugin manager.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also document this method in doc/languages-frameworks/vim.section.md ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At minimum mentioned it there as an option and add your linked example.

@rvolosatovs
Copy link
Member Author

@Mic92

vim-addon-nix throws weird errors on startup
@Mic92 Mic92 merged commit d330154 into NixOS:master Sep 20, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 20, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants