openspin: init at 2018-10-02 #46753

redvers · 2018-09-16T17:11:39Z

Motivation for this change

OpenSpin is an open source compiler for the Parallax Propeller MCU. Additional package for those propeller developers who run on NixOS.

Things done

[✔] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- [ ✔] NixOS
- macOS
- other Linux distributions
[N/A] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[N/A] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[✔] Tested execution of all binary files (usually in ./result/bin/)
[N/A] Determined the impact on package closure size (by running nix path-info -S before and after)
[✔] Fits CONTRIBUTING.md.

adisbladis · 2018-09-16T17:13:03Z

@GrahamcOfBorg build openspin

GrahamcOfBorg · 2018-09-16T17:13:19Z

Failure on x86_64-darwin (full log)

Attempted: openspin

Partial log (click to expand)

make -C PropellerCompiler CROSS= BUILD=/private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/build/PropellerCompiler all
make[1]: Entering directory '/private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/PropellerCompiler'
mkdir -p /private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/build/PropellerCompiler
g++ -Wall -g -Wno-self-assign -o /private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/build/PropellerCompiler/BlockNestStackRoutines.o -c BlockNestStackRoutines.cpp
/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash: g++: command not found
make[1]: *** [Makefile:61: /private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/build/PropellerCompiler/BlockNestStackRoutines.o] Error 127
make[1]: Leaving directory '/private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/PropellerCompiler'
make: *** [Makefile:46: build/PropellerCompiler/libopenspin.a] Error 2
builder for '/nix/store/w19g4lbcbib6br5rw8gnp69fwhhgp9rs-openspin-unstable-2018-02-26.drv' failed with exit code 2
error: build of '/nix/store/w19g4lbcbib6br5rw8gnp69fwhhgp9rs-openspin-unstable-2018-02-26.drv' failed

GrahamcOfBorg · 2018-09-16T17:13:21Z

Success on x86_64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y15xg4v80v15l4inz7j0rvvcz9ky9s6a-openspin-unstable-2018-02-26
shrinking /nix/store/y15xg4v80v15l4inz7j0rvvcz9ky9s6a-openspin-unstable-2018-02-26/bin/openspin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y15xg4v80v15l4inz7j0rvvcz9ky9s6a-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/y15xg4v80v15l4inz7j0rvvcz9ky9s6a-openspin-unstable-2018-02-26
checking for references to /build in /nix/store/y15xg4v80v15l4inz7j0rvvcz9ky9s6a-openspin-unstable-2018-02-26...
/nix/store/y15xg4v80v15l4inz7j0rvvcz9ky9s6a-openspin-unstable-2018-02-26

GrahamcOfBorg · 2018-09-16T17:13:55Z

Success on aarch64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6jvzxay43crkind6yz5bxnnc7bdmy6wr-openspin-unstable-2018-02-26
shrinking /nix/store/6jvzxay43crkind6yz5bxnnc7bdmy6wr-openspin-unstable-2018-02-26/bin/openspin
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6jvzxay43crkind6yz5bxnnc7bdmy6wr-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/6jvzxay43crkind6yz5bxnnc7bdmy6wr-openspin-unstable-2018-02-26
checking for references to /build in /nix/store/6jvzxay43crkind6yz5bxnnc7bdmy6wr-openspin-unstable-2018-02-26...
/nix/store/6jvzxay43crkind6yz5bxnnc7bdmy6wr-openspin-unstable-2018-02-26

adisbladis · 2018-09-16T17:22:03Z

The darwin stdenv does not use gcc but clang. The upstream makefile hardcodes these https://github.com/parallaxinc/OpenSpin/blob/master/Makefile#L16 so a substitution is required.

infinisil · 2018-09-16T17:30:23Z

Using gccStdenv might work

srhb · 2018-09-16T17:51:00Z

@GrahamcOfBorg build openspin

GrahamcOfBorg · 2018-09-16T17:51:37Z

Failure on x86_64-darwin (full log)

Attempted: openspin

Partial log (click to expand)

make -C PropellerCompiler CROSS= BUILD=/private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/build/PropellerCompiler all
make[1]: Entering directory '/private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/PropellerCompiler'
mkdir -p /private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/build/PropellerCompiler
g++ -Wall -g -Wno-self-assign -o /private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/build/PropellerCompiler/BlockNestStackRoutines.o -c BlockNestStackRoutines.cpp
/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash: g++: command not found
make[1]: *** [Makefile:61: /private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/build/PropellerCompiler/BlockNestStackRoutines.o] Error 127
make[1]: Leaving directory '/private/tmp/nix-build-openspin-unstable-2018-02-26.drv-0/source/PropellerCompiler'
make: *** [Makefile:27: build/PropellerCompiler/libopenspin.a] Error 2
builder for '/nix/store/08y1hkh13qbyibaj7dkjq5ppggigxcql-openspin-unstable-2018-02-26.drv' failed with exit code 2
error: build of '/nix/store/08y1hkh13qbyibaj7dkjq5ppggigxcql-openspin-unstable-2018-02-26.drv' failed

GrahamcOfBorg · 2018-09-16T17:51:43Z

Success on x86_64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mc0s6zzsdw1qa6pscwg0ni0wikpcgbk4-openspin-unstable-2018-02-26
shrinking /nix/store/mc0s6zzsdw1qa6pscwg0ni0wikpcgbk4-openspin-unstable-2018-02-26/bin/openspin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mc0s6zzsdw1qa6pscwg0ni0wikpcgbk4-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/mc0s6zzsdw1qa6pscwg0ni0wikpcgbk4-openspin-unstable-2018-02-26
checking for references to /build in /nix/store/mc0s6zzsdw1qa6pscwg0ni0wikpcgbk4-openspin-unstable-2018-02-26...
/nix/store/mc0s6zzsdw1qa6pscwg0ni0wikpcgbk4-openspin-unstable-2018-02-26

GrahamcOfBorg · 2018-09-16T17:51:48Z

Success on aarch64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fli3lpqqsgfm42a6xwwmdiqn2srdha6w-openspin-unstable-2018-02-26
shrinking /nix/store/fli3lpqqsgfm42a6xwwmdiqn2srdha6w-openspin-unstable-2018-02-26/bin/openspin
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fli3lpqqsgfm42a6xwwmdiqn2srdha6w-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/fli3lpqqsgfm42a6xwwmdiqn2srdha6w-openspin-unstable-2018-02-26
checking for references to /build in /nix/store/fli3lpqqsgfm42a6xwwmdiqn2srdha6w-openspin-unstable-2018-02-26...
/nix/store/fli3lpqqsgfm42a6xwwmdiqn2srdha6w-openspin-unstable-2018-02-26

srhb · 2018-09-16T17:57:33Z

@GrahamcOfBorg build openspin

GrahamcOfBorg · 2018-09-16T17:57:48Z

Success on x86_64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/js7jvzqfjq214yv0751z25bm473drcp3-openspin-unstable-2018-02-26
shrinking /nix/store/js7jvzqfjq214yv0751z25bm473drcp3-openspin-unstable-2018-02-26/bin/openspin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/js7jvzqfjq214yv0751z25bm473drcp3-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/js7jvzqfjq214yv0751z25bm473drcp3-openspin-unstable-2018-02-26
checking for references to /build in /nix/store/js7jvzqfjq214yv0751z25bm473drcp3-openspin-unstable-2018-02-26...
/nix/store/js7jvzqfjq214yv0751z25bm473drcp3-openspin-unstable-2018-02-26

GrahamcOfBorg · 2018-09-16T17:57:54Z

Success on x86_64-darwin (full log)

Attempted: openspin

Partial log (click to expand)

clang++ -Wall -g -Wno-self-assign -o build/pathentry.o -c SpinSource/pathentry.cpp
clang++ -o ./build/openspin -Wall -g -Wno-self-assign ./build/openspin.o ./build/pathentry.o ./build/PropellerCompiler/libopenspin.a
running tests
no check/test target in Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/m8xfkb5djjdf4x124sl9z76ixh0cs24m-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/m8xfkb5djjdf4x124sl9z76ixh0cs24m-openspin-unstable-2018-02-26
/nix/store/m8xfkb5djjdf4x124sl9z76ixh0cs24m-openspin-unstable-2018-02-26

GrahamcOfBorg · 2018-09-16T17:58:25Z

Success on aarch64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3bf23llnspswjh9dziyh0lgkg2v1771r-openspin-unstable-2018-02-26
shrinking /nix/store/3bf23llnspswjh9dziyh0lgkg2v1771r-openspin-unstable-2018-02-26/bin/openspin
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3bf23llnspswjh9dziyh0lgkg2v1771r-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/3bf23llnspswjh9dziyh0lgkg2v1771r-openspin-unstable-2018-02-26
checking for references to /build in /nix/store/3bf23llnspswjh9dziyh0lgkg2v1771r-openspin-unstable-2018-02-26...
/nix/store/3bf23llnspswjh9dziyh0lgkg2v1771r-openspin-unstable-2018-02-26

pkgs/development/compilers/openspin/default.nix

srhb · 2018-09-16T18:09:34Z

@GrahamcOfBorg build openspin

GrahamcOfBorg · 2018-09-16T18:09:49Z

Success on x86_64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l2n7swbwnhgax16ysilw1wygfl13p2qr-openspin-2018-02-26
shrinking /nix/store/l2n7swbwnhgax16ysilw1wygfl13p2qr-openspin-2018-02-26/bin/openspin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l2n7swbwnhgax16ysilw1wygfl13p2qr-openspin-2018-02-26/bin
patching script interpreter paths in /nix/store/l2n7swbwnhgax16ysilw1wygfl13p2qr-openspin-2018-02-26
checking for references to /build in /nix/store/l2n7swbwnhgax16ysilw1wygfl13p2qr-openspin-2018-02-26...
/nix/store/l2n7swbwnhgax16ysilw1wygfl13p2qr-openspin-2018-02-26

GrahamcOfBorg · 2018-09-16T18:09:49Z

Success on x86_64-darwin (full log)

Attempted: openspin

Partial log (click to expand)

clang++ -Wall -g -Wno-self-assign -o build/pathentry.o -c SpinSource/pathentry.cpp
clang++ -o ./build/openspin -Wall -g -Wno-self-assign ./build/openspin.o ./build/pathentry.o ./build/PropellerCompiler/libopenspin.a
running tests
no check/test target in Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/r11icbadhi3i86877cbxam7mkgpfl1cq-openspin-2018-02-26/bin
patching script interpreter paths in /nix/store/r11icbadhi3i86877cbxam7mkgpfl1cq-openspin-2018-02-26
/nix/store/r11icbadhi3i86877cbxam7mkgpfl1cq-openspin-2018-02-26

GrahamcOfBorg · 2018-09-16T18:10:24Z

Success on aarch64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p823rvl4866nzk027pci01y3vbz4nrbb-openspin-2018-02-26
shrinking /nix/store/p823rvl4866nzk027pci01y3vbz4nrbb-openspin-2018-02-26/bin/openspin
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p823rvl4866nzk027pci01y3vbz4nrbb-openspin-2018-02-26/bin
patching script interpreter paths in /nix/store/p823rvl4866nzk027pci01y3vbz4nrbb-openspin-2018-02-26
checking for references to /build in /nix/store/p823rvl4866nzk027pci01y3vbz4nrbb-openspin-2018-02-26...
/nix/store/p823rvl4866nzk027pci01y3vbz4nrbb-openspin-2018-02-26

pkgs/development/compilers/openspin/default.nix

adisbladis · 2018-09-19T03:10:41Z

@GrahamcOfBorg build openspin

GrahamcOfBorg · 2018-09-19T03:11:06Z

Success on x86_64-darwin (full log)

Attempted: openspin

Partial log (click to expand)

clang++ -Wall -g -Wno-self-assign -o build/pathentry.o -c SpinSource/pathentry.cpp
clang++ -o ./build/openspin -Wall -g -Wno-self-assign ./build/openspin.o ./build/pathentry.o ./build/PropellerCompiler/libopenspin.a
running tests
no check/test target in Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/bms03cqk7a6knk44h5xs7qlbydcs062d-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/bms03cqk7a6knk44h5xs7qlbydcs062d-openspin-unstable-2018-02-26
/nix/store/bms03cqk7a6knk44h5xs7qlbydcs062d-openspin-unstable-2018-02-26

redvers · 2018-09-30T23:34:42Z

Ok - it should now be good to go. Just need confirmation from @jtojnar regarding how I dealt with the upstream hard-coded compiler issue.

jtojnar · 2018-09-30T23:47:48Z

@GrahamcOfBorg build openspin

GrahamcOfBorg · 2018-09-30T23:48:10Z

Success on x86_64-darwin (full log)

Attempted: openspin

Partial log (click to expand)

clang++ -Wall -g -Wno-self-assign -o build/pathentry.o -c SpinSource/pathentry.cpp
clang++ -o ./build/openspin -Wall -g -Wno-self-assign ./build/openspin.o ./build/pathentry.o ./build/PropellerCompiler/libopenspin.a
running tests
no check/test target in Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/19ay4jh8k6g8wic8ivwcdy4bjdzral66-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/19ay4jh8k6g8wic8ivwcdy4bjdzral66-openspin-unstable-2018-02-26
/nix/store/19ay4jh8k6g8wic8ivwcdy4bjdzral66-openspin-unstable-2018-02-26

GrahamcOfBorg · 2018-09-30T23:48:11Z

Success on aarch64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5rvdybc3jml93qzjinw1gc22bx5qfmcz-openspin-unstable-2018-02-26
shrinking /nix/store/5rvdybc3jml93qzjinw1gc22bx5qfmcz-openspin-unstable-2018-02-26/bin/openspin
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5rvdybc3jml93qzjinw1gc22bx5qfmcz-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/5rvdybc3jml93qzjinw1gc22bx5qfmcz-openspin-unstable-2018-02-26
checking for references to /build in /nix/store/5rvdybc3jml93qzjinw1gc22bx5qfmcz-openspin-unstable-2018-02-26...
/nix/store/5rvdybc3jml93qzjinw1gc22bx5qfmcz-openspin-unstable-2018-02-26

GrahamcOfBorg · 2018-09-30T23:48:39Z

Success on x86_64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vdxr0mqs7nfjp0hpmldp9zsikdsadn36-openspin-unstable-2018-02-26
shrinking /nix/store/vdxr0mqs7nfjp0hpmldp9zsikdsadn36-openspin-unstable-2018-02-26/bin/openspin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vdxr0mqs7nfjp0hpmldp9zsikdsadn36-openspin-unstable-2018-02-26/bin
patching script interpreter paths in /nix/store/vdxr0mqs7nfjp0hpmldp9zsikdsadn36-openspin-unstable-2018-02-26
checking for references to /build in /nix/store/vdxr0mqs7nfjp0hpmldp9zsikdsadn36-openspin-unstable-2018-02-26...
/nix/store/vdxr0mqs7nfjp0hpmldp9zsikdsadn36-openspin-unstable-2018-02-26

jtojnar · 2018-09-30T23:48:56Z

Could you open an issue upstream and add a comment with a link next to the sed hack?

redvers · 2018-10-01T15:00:49Z

Could you open an issue upstream and add a comment with a link next to the sed hack?

Even better, I've written a PR for them. Going to switch to my repo and back to make sure it resolves the issue. Assuming it does (it should), I'll publish. Making WIP.

grahamc · 2018-10-01T23:34:03Z

@GrahamcOfBorg build openspin

GrahamcOfBorg · 2018-10-01T23:34:22Z

Success on x86_64-darwin (full log)

Attempted: openspin

Partial log (click to expand)

clang++ -Wall -g -Wno-self-assign -o build/pathentry.o -c SpinSource/pathentry.cpp
clang++ -o ./build/openspin -Wall -g -Wno-self-assign ./build/openspin.o ./build/pathentry.o ./build/PropellerCompiler/libopenspin.a
running tests
no check/test target in Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/vnm0as0z51fwwp6vkiag1q54n77xdan1-openspin-unstable-2018-10-01/bin
patching script interpreter paths in /nix/store/vnm0as0z51fwwp6vkiag1q54n77xdan1-openspin-unstable-2018-10-01
/nix/store/vnm0as0z51fwwp6vkiag1q54n77xdan1-openspin-unstable-2018-10-01

GrahamcOfBorg · 2018-10-01T23:34:22Z

Success on x86_64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zk56d8sjbkc4cz03rm229ff33ac3a1f3-openspin-unstable-2018-10-01
shrinking /nix/store/zk56d8sjbkc4cz03rm229ff33ac3a1f3-openspin-unstable-2018-10-01/bin/openspin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zk56d8sjbkc4cz03rm229ff33ac3a1f3-openspin-unstable-2018-10-01/bin
patching script interpreter paths in /nix/store/zk56d8sjbkc4cz03rm229ff33ac3a1f3-openspin-unstable-2018-10-01
checking for references to /build in /nix/store/zk56d8sjbkc4cz03rm229ff33ac3a1f3-openspin-unstable-2018-10-01...
/nix/store/zk56d8sjbkc4cz03rm229ff33ac3a1f3-openspin-unstable-2018-10-01

GrahamcOfBorg · 2018-10-01T23:34:27Z

Success on aarch64-linux (full log)

Attempted: openspin

Partial log (click to expand)

no check/test target in Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/23p2yvy1hfhzfgdyvvky7wj0pci46q4m-openspin-unstable-2018-10-01
shrinking /nix/store/23p2yvy1hfhzfgdyvvky7wj0pci46q4m-openspin-unstable-2018-10-01/bin/openspin
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/23p2yvy1hfhzfgdyvvky7wj0pci46q4m-openspin-unstable-2018-10-01/bin
patching script interpreter paths in /nix/store/23p2yvy1hfhzfgdyvvky7wj0pci46q4m-openspin-unstable-2018-10-01
checking for references to /build in /nix/store/23p2yvy1hfhzfgdyvvky7wj0pci46q4m-openspin-unstable-2018-10-01...
/nix/store/23p2yvy1hfhzfgdyvvky7wj0pci46q4m-openspin-unstable-2018-10-01

redvers · 2018-10-02T03:06:22Z

Could you open an issue upstream and add a comment with a link next to the sed hack?

Even better, I've written a PR for them. Going to switch to my repo and back to make sure it resolves the issue. Assuming it does (it should), I'll publish. Making WIP.

They accepted my PR - I'm updated to their latest commit.

Thanks,

Red

jtojnar · 2018-10-02T03:23:07Z

@GrahamcOfBorg build openspin

jtojnar · 2018-10-02T03:22:21Z

pkgs/development/compilers/openspin/default.nix

+    sha256 = "1knkbzdanb60cwp7mggymkhd0167lh2sb1c00d1vhw7s0s1rj96n";
+  };
+
+  installPhase = ''


Maybe you could also try add install target to upstream Makefile.

I'm not comfortable in doing that. They already have their own CI integration that cross-compiles it to multiple platforms. Their CI system then pulls the artifacts out for packaging for end-users.

I don't feel comfortable suggesting that change upstream.

GrahamcOfBorg · 2018-10-02T03:23:33Z

Success on x86_64-linux (full log)

Attempted: openspin

Partial log (click to expand)

g++ -o ./build/openspin -Wall -g  ./build/openspin.o ./build/pathentry.o ./build/PropellerCompiler/libopenspin.a
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6yd2pdpymilvzdald2dc71gdwhw6c6hf-openspin-unstable-2018-10-02
shrinking /nix/store/6yd2pdpymilvzdald2dc71gdwhw6c6hf-openspin-unstable-2018-10-02/bin/openspin
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6yd2pdpymilvzdald2dc71gdwhw6c6hf-openspin-unstable-2018-10-02/bin
patching script interpreter paths in /nix/store/6yd2pdpymilvzdald2dc71gdwhw6c6hf-openspin-unstable-2018-10-02
checking for references to /build in /nix/store/6yd2pdpymilvzdald2dc71gdwhw6c6hf-openspin-unstable-2018-10-02...
/nix/store/6yd2pdpymilvzdald2dc71gdwhw6c6hf-openspin-unstable-2018-10-02

GrahamcOfBorg · 2018-10-02T03:23:39Z

Success on aarch64-linux (full log)

Attempted: openspin

Partial log (click to expand)

g++ -o ./build/openspin -Wall -g  ./build/openspin.o ./build/pathentry.o ./build/PropellerCompiler/libopenspin.a
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/675swkrz4r60vlgpbmafxy81c36280xd-openspin-unstable-2018-10-02
shrinking /nix/store/675swkrz4r60vlgpbmafxy81c36280xd-openspin-unstable-2018-10-02/bin/openspin
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/675swkrz4r60vlgpbmafxy81c36280xd-openspin-unstable-2018-10-02/bin
patching script interpreter paths in /nix/store/675swkrz4r60vlgpbmafxy81c36280xd-openspin-unstable-2018-10-02
checking for references to /build in /nix/store/675swkrz4r60vlgpbmafxy81c36280xd-openspin-unstable-2018-10-02...
/nix/store/675swkrz4r60vlgpbmafxy81c36280xd-openspin-unstable-2018-10-02

GrahamcOfBorg · 2018-10-02T03:23:45Z

Success on x86_64-darwin (full log)

Attempted: openspin

Partial log (click to expand)

make[1]: Leaving directory '/private/tmp/nix-build-openspin-unstable-2018-10-02.drv-0/source/PropellerCompiler'
clang++ -Wall -g -Wno-self-assign -o build/openspin.o -c SpinSource/openspin.cpp
clang++ -Wall -g -Wno-self-assign -o build/pathentry.o -c SpinSource/pathentry.cpp
clang++ -o ./build/openspin -Wall -g -Wno-self-assign ./build/openspin.o ./build/pathentry.o ./build/PropellerCompiler/libopenspin.a
installing
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/gg5agp4a13ws3p2dd4bc1n0w4w3bb756-openspin-unstable-2018-10-02/bin
patching script interpreter paths in /nix/store/gg5agp4a13ws3p2dd4bc1n0w4w3bb756-openspin-unstable-2018-10-02
/nix/store/gg5agp4a13ws3p2dd4bc1n0w4w3bb756-openspin-unstable-2018-10-02

redvers changed the title ~~openspin: init at 2018-02-26~~ WIP: openspin: init at 2018-02-26 (fixing darwin autotesting) Sep 16, 2018

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 16, 2018

GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Sep 16, 2018

srhb reviewed Sep 16, 2018

View reviewed changes

pkgs/development/compilers/openspin/default.nix Outdated Show resolved Hide resolved

redvers force-pushed the add/openspin branch 2 times, most recently from 98bdf82 to da56fc8 Compare September 16, 2018 18:06

redvers changed the title ~~WIP: openspin: init at 2018-02-26 (fixing darwin autotesting)~~ openspin: init at 2018-02-26 Sep 16, 2018

jtojnar requested changes Sep 18, 2018

View reviewed changes

GrahamcOfBorg removed the 10.rebuild-linux: 1-10 label Sep 30, 2018

redvers changed the title ~~openspin: init at 2018-02-26~~ WIP: openspin: init at 2018-02-26 Oct 1, 2018

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Oct 1, 2018

redvers mentioned this pull request Oct 2, 2018

Change behaviour: Makefiles had gcc/g++ hard-coded ignoring CC/CXX env parallaxinc/OpenSpin#39

Merged

redvers changed the title ~~WIP: openspin: init at 2018-02-26~~ openspin: init at 2018-10-01 Oct 2, 2018

redvers force-pushed the add/openspin branch from 74dcaf5 to 3f6fc90 Compare October 2, 2018 01:22

openspin: init at 2018-10-02

19e7ae0

redvers force-pushed the add/openspin branch from 3f6fc90 to 19e7ae0 Compare October 2, 2018 03:03

redvers changed the title ~~openspin: init at 2018-10-01~~ openspin: init at 2018-10-02 Oct 2, 2018

jtojnar reviewed Oct 2, 2018

View reviewed changes

infinisil merged commit 9a3e418 into NixOS:master Oct 17, 2018

openspin: init at 2018-10-02 #46753

openspin: init at 2018-10-02 #46753

Conversation

redvers commented Sep 16, 2018 • edited

Motivation for this change

Things done

adisbladis commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

adisbladis commented Sep 16, 2018

infinisil commented Sep 16, 2018

srhb commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

srhb commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

srhb commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

GrahamcOfBorg commented Sep 16, 2018

adisbladis commented Sep 19, 2018

GrahamcOfBorg commented Sep 19, 2018

redvers commented Sep 30, 2018

jtojnar commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

jtojnar commented Sep 30, 2018 • edited

redvers commented Oct 1, 2018

grahamc commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

redvers commented Oct 2, 2018

jtojnar commented Oct 2, 2018

jtojnar Oct 2, 2018

Choose a reason for hiding this comment

redvers Oct 2, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

redvers commented Sep 16, 2018 •

edited

jtojnar commented Sep 30, 2018 •

edited