Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vivaldi: 1.15.1147.42-1 -> 1.15.1147.64-1 #46758

Merged
merged 2 commits into from Sep 17, 2018
Merged

vivaldi: 1.15.1147.42-1 -> 1.15.1147.64-1 #46758

merged 2 commits into from Sep 17, 2018

Conversation

lluchs
Copy link
Contributor

@lluchs lluchs commented Sep 16, 2018 •
edited

Motivation for this change

Package update. Also fixes the vivaldi-ffmpeg-codecs package.

Fixes #39590

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

vivaldi is unfree, but we can try to build the codecs:
@GrahamcOfBorg build vivaldi-ffmpeg-codecs

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vivaldi-ffmpeg-codecs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: vivaldi-ffmpeg-codecs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vivaldi-ffmpeg-codecs

Partial log (click to expand)

[610/610] python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libffmpeg.so" --tocfile="./libffmpeg.so.TOC" --output="./libffmpeg.so"  -- g++ -shared -Wl,-Bsymbolic -L gen/third_party/ffmpeg -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -m64 -Wl,-O2 -Wl,--gc-sections -rdynamic -o "./libffmpeg.so" -Wl,-soname="libffmpeg.so" @"./libffmpeg.so.rsp"
glibPreInstallPhase
installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9mzccphgxs734lqvv1krkfhp58cjbwf6-vivaldi-ffmpeg-codecs-69.0.3497.73
shrinking /nix/store/9mzccphgxs734lqvv1krkfhp58cjbwf6-vivaldi-ffmpeg-codecs-69.0.3497.73/lib/libffmpeg.so
patching script interpreter paths in /nix/store/9mzccphgxs734lqvv1krkfhp58cjbwf6-vivaldi-ffmpeg-codecs-69.0.3497.73
checking for references to /build in /nix/store/9mzccphgxs734lqvv1krkfhp58cjbwf6-vivaldi-ffmpeg-codecs-69.0.3497.73...
/nix/store/9mzccphgxs734lqvv1krkfhp58cjbwf6-vivaldi-ffmpeg-codecs-69.0.3497.73

@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

checked the build of unfree vivaldi browser locally, LGTM.

@xeji xeji merged commit 5c7406c into NixOS:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vivaldi-ffmpeg-codecs build fails
3 participants
@lluchs @xeji @GrahamcOfBorg