Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

any-nix-shell: init at 1.1.0 #46743

Merged
merged 2 commits into from Oct 8, 2018
Merged

any-nix-shell: init at 1.1.0 #46743

merged 2 commits into from Oct 8, 2018

Conversation

haslersn
Copy link
Contributor

@haslersn haslersn commented Sep 16, 2018 •
edited

Motivation for this change

This adds fish and zsh support for both nix run and nix-shell. More supported shells can be added in the future.

Supersedes #46630 as this is version 1.1.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@haslersn haslersn mentioned this pull request Sep 16, 2018
Closed
9 tasks
@matthewbauer
Copy link
Member

@GrahamcOfBorg any-nix-shell

@joachifm
Copy link
Contributor

joachifm commented Oct 8, 2018

@GrahamcOfBorg build any-nix-shell

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: any-nix-shell

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0/bin
patching script interpreter paths in /nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0
/nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0/bin/.any-nix-shell-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0/bin/nix-shell-info: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0/bin/.any-nix-shell-wrapper: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
/nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0/bin/.any-nix-run-wrapper: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0...
/nix/store/m0f347mldvgh93frg60gbryq6rz754lb-any-nix-shell-1.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: any-nix-shell

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0/bin
patching script interpreter paths in /nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0
/nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0/bin/nix-shell-info: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0/bin/.any-nix-run-wrapper: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0/bin/.any-nix-shell-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
/nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0/bin/.any-nix-shell-wrapper: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0...
/nix/store/jhkqxn90kgsi5kdaip8rpkw7zyhr503k-any-nix-shell-1.1.0

@joachifm joachifm merged commit 6bfc436 into NixOS:master Oct 8, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: any-nix-shell

Partial log (click to expand)

installing
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fwnjppny28ryfql8rmg4746x47jg5z94-any-nix-shell-1.1.0/bin
patching script interpreter paths in /nix/store/fwnjppny28ryfql8rmg4746x47jg5z94-any-nix-shell-1.1.0
/nix/store/fwnjppny28ryfql8rmg4746x47jg5z94-any-nix-shell-1.1.0/bin/.any-nix-run-wrapper: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/fwnjppny28ryfql8rmg4746x47jg5z94-any-nix-shell-1.1.0/bin/.any-nix-shell-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/fwnjppny28ryfql8rmg4746x47jg5z94-any-nix-shell-1.1.0/bin/.any-nix-shell-wrapper: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/fwnjppny28ryfql8rmg4746x47jg5z94-any-nix-shell-1.1.0/bin/nix-shell-info: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
/nix/store/fwnjppny28ryfql8rmg4746x47jg5z94-any-nix-shell-1.1.0

haslersn added a commit to haslersn/any-nix-shell that referenced this pull request Oct 23, 2018
@haslersn
README: Suggest getting any-nix-shell from nixpkgs master
8aa4ae9 
This is possible since NixOS/nixpkgs#46743 got merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haslersn @matthewbauer @joachifm @GrahamcOfBorg