Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocode: c7fddb39 -> 00e7f5ac #46107

Merged
merged 1 commit into from Sep 5, 2018
Merged

gocode: c7fddb39 -> 00e7f5ac #46107

merged 1 commit into from Sep 5, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Sep 5, 2018 •
edited

Motivation for this change

Also, switch to the now-maintained fork of gocode available at github.com/mdempsky/gocode because github.com/nsf/gocode is now unmaintained.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kalbasit
gocode: c7fddb39ecbc9ebd1ebe7d2a3af473ed0fffffa1 -> 00e7f5ac290aeb20a…
f2035dc 
…3d8d31e737ae560a191a1d5

Also, switch to the now-maintained fork of gocode available at github.com/mdempsky/gocode
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gocode

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/igj9ihz2fg5a7ghrfxfgs88ggdkscxg2-gocode-20180727-00e7f5a-bin
shrinking /nix/store/igj9ihz2fg5a7ghrfxfgs88ggdkscxg2-gocode-20180727-00e7f5a-bin/bin/gocode
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/igj9ihz2fg5a7ghrfxfgs88ggdkscxg2-gocode-20180727-00e7f5a-bin/bin
patching script interpreter paths in /nix/store/igj9ihz2fg5a7ghrfxfgs88ggdkscxg2-gocode-20180727-00e7f5a-bin
checking for references to /build in /nix/store/igj9ihz2fg5a7ghrfxfgs88ggdkscxg2-gocode-20180727-00e7f5a-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/igj9ihz2fg5a7ghrfxfgs88ggdkscxg2-gocode-20180727-00e7f5a-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gocode

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/is0ksaz99zm9d1nc4kwjiw7jpjqb87r8-gocode-20180727-00e7f5a-bin
shrinking /nix/store/is0ksaz99zm9d1nc4kwjiw7jpjqb87r8-gocode-20180727-00e7f5a-bin/bin/gocode
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/is0ksaz99zm9d1nc4kwjiw7jpjqb87r8-gocode-20180727-00e7f5a-bin/bin
patching script interpreter paths in /nix/store/is0ksaz99zm9d1nc4kwjiw7jpjqb87r8-gocode-20180727-00e7f5a-bin
checking for references to /build in /nix/store/is0ksaz99zm9d1nc4kwjiw7jpjqb87r8-gocode-20180727-00e7f5a-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/is0ksaz99zm9d1nc4kwjiw7jpjqb87r8-gocode-20180727-00e7f5a-bin

@xeji xeji merged commit 7e74013 into NixOS:master Sep 5, 2018
@kalbasit kalbasit deleted the nixpkgs_update-gocode branch September 5, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @GrahamcOfBorg @xeji