Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify: 1.0.88.353.g15c26ea1-14 -> 1.0.83.316.ge96b6e67-5 #46099

Merged
merged 1 commit into from Sep 5, 2018
Merged

spotify: 1.0.88.353.g15c26ea1-14 -> 1.0.83.316.ge96b6e67-5 #46099

merged 1 commit into from Sep 5, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Sep 5, 2018

Motivation for this change

The recent update is broken. Playing a song causes spotify to segfault.
This is probably
https://community.spotify.com/t5/Desktop-Linux/Segfault-with-the-new-update/td-p/4554830#,
which was recognized by upstream and will hopefully be fixed soon.

I pushed the update myself but I have to admit that I didn't test it at the time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
spotify: 1.0.88.353.g15c26ea1-14 -> 1.0.83.316.ge96b6e67-5
d89b1f0 
The recent update is broken. Playing a song causes spotify to segfault.
This is probably
https://community.spotify.com/t5/Desktop-Linux/Segfault-with-the-new-update/td-p/4554830#,
which was recognized by upstream and will hopefully be fixed soon.
@timokau timokau added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 5, 2018
@timokau timokau merged commit 0e37f90 into NixOS:master Sep 5, 2018
@timokau timokau mentioned this pull request Sep 5, 2018
Closed
@timokau timokau deleted the spotify-17 branch September 5, 2018 15:53
@timokau timokau removed the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg