bintools-wrapper, cc-wrapper: infer propagateDoc automatically #46119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GrahamcOfBorg
added
6.topic: stdenv
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
oxij
force-pushed
the
stdenv/bintools-cc-autopropagate
branch
from
09721c6
to
1bb1e7a
Compare
oxij
changed the title
oxij
force-pushed
the
stdenv/bintools-cc-autopropagate
branch
2 times, most recently
from
d0270a3
to
5297be3
Compare
oxij
force-pushed
the
stdenv/bintools-cc-autopropagate
branch
from
5297be3
to
c8ba9df
Compare
GrahamcOfBorg
added
10.rebuild-linux: 101-500
and removed
10.rebuild-linux-stdenv
10.rebuild-linux: 501+
labels
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
oxij
force-pushed
the
stdenv/bintools-cc-autopropagate
branch
from
c8ba9df
to
c33cf36
Compare
GrahamcOfBorg
added
10.rebuild-darwin: 11-100
and removed
10.rebuild-darwin-stdenv
10.rebuild-darwin: 501+
labels
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
oxij
force-pushed
the
stdenv/bintools-cc-autopropagate
branch
from
c33cf36
to
afe6c1c
Compare
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
labels
|
Success on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Yay, a noop! But look at the pinned values of |
Ericson2314
approved these changes
Sep 6, 2018
…y, but ... ... pin the old values in everywhere to avoid a mass rebuild.
Ericson2314
force-pushed
the
stdenv/bintools-cc-autopropagate
branch
from
afe6c1c
to
6805be7
Compare
|
I bet we could simplify this, but yeah looks good for now.
I'm 👎 on merging this.
Like I said in #46115 (comment), I think this is a nice demo that shows how broken those wrappers are on master (`propagateDoc` values are pretty much random), but it makes no sense to merge this PR alone, as it changes nothing w.r.t. the brokenness, but adds a ton of useless workarounds to be a noop.
Fixing brokenness does take a mass rebuild, i.e. #46115.
|
|
Oh. Well I won't on principle merge a PR that the author doesn't want merged, but I still think it would be good to use this. Then you can make the other remove all the hacks, old and new, which most clearly indicates the benefit symlinks. |
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Symlinks are a separate issue. My problem here is that, as it turns out, This whole issue has long run out of its allocated time, so I'm not going to change anything related unless the motivation for that is internal for a while now. Closing this, feel free to do whatever, but I think #46115 is the correct thing to do, I'm merging that to SLNOS. |
oxij
added a commit
to oxij/nixpkgs
that referenced
this pull request
Sep 23, 2018
02c09e0 (NixOS#44558) was reverted in c981787 but, as it turns out, it fixed an issue I didn't know about at the time: the values of `propagateDoc` options were (and now again are) inconsistent with the underlying things those wrappers wrap (see NixOS#46119), which was (and now is) likely to produce more instances of NixOS#43547, if not now, then eventually as stdenv changes. This patch (which is a simplified version of the original reverted patch) is the simplest solution to this whole thing: it forces wrappers to directly inspect the outputs of the things they are wrapping instead of making stdenv guess the correct values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #43547. This is a piece of #46115.