New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noti: init at 3.1.0 #46111
noti: init at 3.1.0 #46111
Conversation
77d2de2
to
eb6bd48
Compare
@srhb -- Please take a look! I'm a bit iffy on the proper way to set up documentation -- I think the I'm also a bit iffy on go in general, but luckily nix makes it easy to figure out the build process. : ) |
Most of the goPackages that manually install man pages I could find do what you do. It does seem a bit weird to me, because they end up in the bin output. Maybe they ought to have a doc output instead. |
noti, especially, has a decently sized Makefile which originally lead me to believe it had a non-standard build. This repo doesn't seem to output the man pages, anyhow, and they come pre-build in the repo. |
Thanks @stites. One last thing: Please squash this into one commit following the rules at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes (ie. "noti: init at 3.1.0") or two commits, one for this addition and one "add stites to maintainer list" :) Thanks a lot for your effort, and welcome to the nixpkgs maintainers list. 😃 |
Thank you for the guidance, this was a lot of fun! |
Motivation for this change
Add a new, works-out-of-the-box notifier
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)First-time submitter! let me know if I should move this package somewhere else, or if anything is wrong.