Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noti: init at 3.1.0 #46111

Merged
merged 2 commits into from Sep 7, 2018
Merged

noti: init at 3.1.0 #46111

merged 2 commits into from Sep 7, 2018

Conversation

stites
Copy link
Member

@stites stites commented Sep 5, 2018

Motivation for this change

Add a new, works-out-of-the-box notifier

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: Ubunt17.04
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

First-time submitter! let me know if I should move this package somewhere else, or if anything is wrong.

pkgs/tools/misc/noti/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/noti/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/noti/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/noti/default.nix Outdated Show resolved Hide resolved
@stites
Copy link
Member Author

stites commented Sep 6, 2018

@srhb -- Please take a look! I'm a bit iffy on the proper way to set up documentation -- I think the postInstall is correct (as in "works on my machine"), but I'm not sure if there's a better way to do this.

I'm also a bit iffy on go in general, but luckily nix makes it easy to figure out the build process. : )

pkgs/tools/misc/noti/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/noti/default.nix Outdated Show resolved Hide resolved
@srhb
Copy link
Contributor

srhb commented Sep 6, 2018

I'm a bit iffy on the proper way to set up documentation

Most of the goPackages that manually install man pages I could find do what you do. It does seem a bit weird to me, because they end up in the bin output. Maybe they ought to have a doc output instead.

@stites
Copy link
Member Author

stites commented Sep 7, 2018

noti, especially, has a decently sized Makefile which originally lead me to believe it had a non-standard build. This repo doesn't seem to output the man pages, anyhow, and they come pre-build in the repo.

@srhb
Copy link
Contributor

srhb commented Sep 7, 2018

Thanks @stites. One last thing: Please squash this into one commit following the rules at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes (ie. "noti: init at 3.1.0") or two commits, one for this addition and one "add stites to maintainer list" :)

Thanks a lot for your effort, and welcome to the nixpkgs maintainers list. 😃

@stites stites closed this Sep 7, 2018
@stites
Copy link
Member Author

stites commented Sep 7, 2018

Thank you for the guidance, this was a lot of fun!

@srhb srhb merged commit 4ae70b7 into NixOS:master Sep 7, 2018
@stites stites deleted the noti branch September 9, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants