Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tflearn: 0.2.1 -> 0.3.2 #46102

Merged
merged 3 commits into from Sep 5, 2018
Merged

pythonPackages.tflearn: 0.2.1 -> 0.3.2 #46102

merged 3 commits into from Sep 5, 2018

Conversation

jethrokuan
Copy link
Contributor

@jethrokuan jethrokuan commented Sep 5, 2018 •
edited

Motivation for this change

ZHF #45960

first time contributor (not active user of this package either), just wanted to try my hand at this and help out.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Sep 5, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
description = "Deep learning library featuring a higher-level API for TensorFlow";
homepage = "https://github.com/tflearn/tflearn";
license = licenses.mit;
src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example refactoring: #45763

@Mic92 Mic92 changed the title tflearn: 0.2.1 -> 0.3.2 pythonPackages.tflearn: 0.2.1 -> 0.3.2 Sep 5, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

@GrahamcOfBorg build pythonPackages.tflearn python3Packages.tflearn

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pythonPackages.tflearn, python3Packages.tflearn

Partial log (click to expand)

building
installing
/build/dist /build
tensorflow-1.9.0-cp27-none-linux_x86_64.whl is not a supported wheel on this platform.
builder for '/nix/store/wb18s90fhk0v6cwckqnjki3yi3qfc80h-python2.7-tensorflow-1.9.0.drv' failed with exit code 1
cannot build derivation '/nix/store/17hc9dc57gi2k26bysizmyfahx9xrd9d-python2.7-tflearn-0.3.2.drv': 1 dependencies couldn't be built
tensorflow-1.9.0-cp36-cp36m-linux_x86_64.whl is not a supported wheel on this platform.
builder for '/nix/store/n70pxmlh7kipxx33za1bpl0sr0cfgr6x-python3.6-tensorflow-1.9.0.drv' failed with exit code 1
cannot build derivation '/nix/store/dygfxx7alf20jlb6yb8lg4d8vvljpyyg-python3.6-tflearn-0.3.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/17hc9dc57gi2k26bysizmyfahx9xrd9d-python2.7-tflearn-0.3.2.drv', '/nix/store/dygfxx7alf20jlb6yb8lg4d8vvljpyyg-python3.6-tflearn-0.3.2.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.tflearn

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.tflearn

Partial log (click to expand)

Requirement already satisfied: six in /nix/store/lzq4ax4glj09dvnipwslav7fxvggcq4s-python3.6-six-1.11.0/lib/python3.6/site-packages (from tflearn==0.3.2) (1.11.0)
Requirement already satisfied: Pillow in /nix/store/h05xl4rhvn5sgy70qc8l53dlb063nsxa-python3.6-Pillow-5.2.0/lib/python3.6/site-packages (from tflearn==0.3.2) (5.2.0)
Installing collected packages: tflearn
Successfully installed tflearn-0.3.2
/private/tmp/nix-build-python3.6-tflearn-0.3.2.drv-0/tflearn-0.3.2
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/83qsm6b43brr17cgc2nd5i98cyz7b7rm-python3.6-tflearn-0.3.2/lib
patching script interpreter paths in /nix/store/83qsm6b43brr17cgc2nd5i98cyz7b7rm-python3.6-tflearn-0.3.2
/nix/store/83qsm6b43brr17cgc2nd5i98cyz7b7rm-python3.6-tflearn-0.3.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.tflearn, python3Packages.tflearn

Partial log (click to expand)

Successfully installed tflearn-0.3.2
/build/tflearn-0.3.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/43lwdq9xm5hs5ijzrr6aga7jlaj6vngi-python3.6-tflearn-0.3.2
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/43lwdq9xm5hs5ijzrr6aga7jlaj6vngi-python3.6-tflearn-0.3.2/lib
patching script interpreter paths in /nix/store/43lwdq9xm5hs5ijzrr6aga7jlaj6vngi-python3.6-tflearn-0.3.2
checking for references to /build in /nix/store/43lwdq9xm5hs5ijzrr6aga7jlaj6vngi-python3.6-tflearn-0.3.2...
/nix/store/v41iyg0adsvvjcb62j7hdfigx1pzdypa-python2.7-tflearn-0.3.2
/nix/store/43lwdq9xm5hs5ijzrr6aga7jlaj6vngi-python3.6-tflearn-0.3.2

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

tensorflow itself is broken too on aarch64, but this is out of scope of this pr.

@Mic92 Mic92 merged commit a9a380b into NixOS:master Sep 5, 2018
Mic92 pushed a commit that referenced this pull request Sep 5, 2018
@jethrokuan @Mic92
pythonPackages.tflearn: 0.2.1 -> 0.3.2 (#46102)
c3796a7 
(cherry picked from commit a9a380b)
@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

[detached HEAD c3796a7] pythonPackages.tflearn: 0.2.1 -> 0.3.2 (#46102)
Author: Jethro Kuan jethrokuan95@gmail.com
Date: Thu Sep 6 00:38:23 2018 +0800
2 files changed, 25 insertions(+), 16 deletions(-)
create mode 100644 pkgs/development/python-modules/tflearn/default.nix

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

Thanks! Backport is above.

@jethrokuan
Copy link
Contributor Author

Thanks for the review!

@jethrokuan jethrokuan deleted the fix/tflearn branch September 5, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jethrokuan @Mic92 @GrahamcOfBorg @Janik-Haag