Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettyping: init at 1.0.1 #46116

Closed
wants to merge 1 commit into from
Closed

prettyping: init at 1.0.1 #46116

wants to merge 1 commit into from

Conversation

stites
Copy link
Member

@stites stites commented Sep 5, 2018

Motivation for this change

Another great script (recently cameo'd in CLI: Improved, Remy Sharp).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: Ubuntu 17.01
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Heads-up, this will conflict with #46111 since both update maintainers.nix at the same place.

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

prettyping was already added in #46008.

@stites
Copy link
Member Author

stites commented Sep 5, 2018

oops!

@stites stites deleted the prettyping branch September 5, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants